Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address scenario where we would crash when replacing a matched vnode with null #4281

Merged
merged 5 commits into from
Feb 16, 2024
Merged

fix: address scenario where we would crash when replacing a matched vnode with null #4281

merged 5 commits into from
Feb 16, 2024

Commits on Feb 16, 2024

  1. add test for the issue, TODO convert to class components later

    @JoviDeCroock
    JoviDeCroock committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    f77b6ee View commit details
    Browse the repository at this point in the history

  2. wip

    @JoviDeCroock
    JoviDeCroock committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    bd37695 View commit details
    Browse the repository at this point in the history

  3. correct assertion

    @JoviDeCroock
    JoviDeCroock committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e542965 View commit details
    Browse the repository at this point in the history

  4. avoid crasshing when replacing existing node

    @JoviDeCroock
    JoviDeCroock committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d1f8ee5 View commit details
    Browse the repository at this point in the history

  5. move test to core

    @JoviDeCroock
    JoviDeCroock committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    ddc0255 View commit details
    Browse the repository at this point in the history