Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major(core): move defaultProps to compat #4361

Open
wants to merge 1 commit into
base: breaking-changes-11
Choose a base branch
from
Open

major(core): move defaultProps to compat #4361

wants to merge 1 commit into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Apr 29, 2024 •
edited

This PR moves defaultProps handling to compat

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-12.89ms - +5.83ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +1% (-0.32ms - +0.09ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +5% (-0.70ms - +3.49ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +5% (-0.36ms - +0.78ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +3% (-1.22ms - +1.94ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +3% (-0.06ms - +0.05ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.50ms - +0.23ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +3% (-0.63ms - +0.85ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.01ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +2% (-0.43ms - +0.26ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 0% - 1% (0.00ms - 0.05ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +3% (-0.06ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local889.08ms - 897.41ms-unsure 🔍
-1% - +1%
-12.89ms - +5.83ms
preact-main888.39ms - 905.15msunsure 🔍
-1% - +1%
-5.83ms - +12.89ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local26.76ms - 26.76ms-unsure 🔍
+0% - +0%
+0.01ms - +0.01ms
preact-main26.75ms - 26.75msunsure 🔍
-0% - -0%
-0.01ms - -0.01ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.63ms - 16.77ms-unsure 🔍
-2% - +1%
-0.32ms - +0.09ms
preact-main16.62ms - 17.01msunsure 🔍
-1% - +2%
-0.09ms - +0.32ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.74ms - 1.74ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.75ms - 1.75msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local75.55ms - 79.60ms-unsure 🔍
-1% - +5%
-0.70ms - +3.49ms
preact-main75.63ms - 76.72msunsure 🔍
-4% - +1%
-3.49ms - +0.70ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local14.05ms - 14.45ms-unsure 🔍
-3% - +2%
-0.43ms - +0.26ms
preact-main14.05ms - 14.61msunsure 🔍
-2% - +3%
-0.26ms - +0.43ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.44ms - 17.35ms-unsure 🔍
-2% - +5%
-0.36ms - +0.78ms
preact-main16.34ms - 17.03msunsure 🔍
-5% - +2%
-0.78ms - +0.36ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.85ms - 4.86ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-main4.86ms - 4.86msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.33ms - 74.25ms-unsure 🔍
-2% - +3%
-1.22ms - +1.94ms
preact-main71.67ms - 74.19msunsure 🔍
-3% - +2%
-1.94ms - +1.22ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.68ms - 3.71ms-slower ❌
0% - 1%
0.00ms - 0.05ms
preact-main3.65ms - 3.68msfaster ✔
0% - 1%
0.00ms - 0.05ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.34ms - 29.31ms-unsure 🔍
-3% - +1%
-0.86ms - +0.36ms
preact-main28.70ms - 29.44msunsure 🔍
-1% - +3%
-0.36ms - +0.86ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.47ms - 37.19ms-unsure 🔍
-6% - +0%
-2.41ms - +0.10ms
preact-main36.57ms - 38.40msunsure 🔍
-0% - +7%
-0.10ms - +2.41ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.17ms - 26.87ms-unsure 🔍
-2% - +1%
-0.65ms - +0.33ms
preact-main26.34ms - 27.03msunsure 🔍
-1% - +2%
-0.33ms - +0.65ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.40ms - 25.32ms-unsure 🔍
-2% - +3%
-0.44ms - +0.85ms
preact-main24.20ms - 25.11msunsure 🔍
-3% - +2%
-0.85ms - +0.44ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local28.84ms - 30.85ms-unsure 🔍
-7% - +3%
-2.02ms - +0.85ms
preact-main29.41ms - 31.45msunsure 🔍
-3% - +7%
-0.85ms - +2.02ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.62ms - 24.91ms-unsure 🔍
-4% - +3%
-1.08ms - +0.73ms
preact-main23.81ms - 25.07msunsure 🔍
-3% - +4%
-0.73ms - +1.08ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.73ms - 1.80ms-unsure 🔍
-3% - +3%
-0.06ms - +0.05ms
preact-main1.73ms - 1.81msunsure 🔍
-3% - +3%
-0.05ms - +0.06ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.16ms - 1.23ms-unsure 🔍
-5% - +3%
-0.06ms - +0.04ms
preact-main1.17ms - 1.24msunsure 🔍
-3% - +5%
-0.04ms - +0.06ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local27.26ms - 27.86ms-unsure 🔍
-2% - +1%
-0.50ms - +0.23ms
preact-main27.49ms - 27.90msunsure 🔍
-1% - +2%
-0.23ms - +0.50ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.20ms - 34.43ms-unsure 🔍
-2% - +3%
-0.63ms - +0.85ms
preact-main33.29ms - 34.11msunsure 🔍
-3% - +2%
-0.85ms - +0.63ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.69ms - 3.69ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main3.69ms - 3.69msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

Size Change: -395 B (0%)

Total Size: 60.7 kB

Filename Size Change
compat/dist/compat.js 4.14 kB +47 B (1%)
compat/dist/compat.module.js 4.07 kB +55 B (1%)
compat/dist/compat.umd.js 4.19 kB +48 B (1%)
dist/preact.js 4.53 kB -77 B (1%)
dist/preact.min.js 4.57 kB -76 B (1%)
dist/preact.min.module.js 4.56 kB -78 B (1%)
dist/preact.min.umd.js 4.59 kB -76 B (1%)
dist/preact.module.js 4.55 kB -75 B (1%)
dist/preact.umd.js 4.6 kB -80 B (1%)
jsx-runtime/dist/jsxRuntime.js 949 B -27 B (2%)
jsx-runtime/dist/jsxRuntime.module.js 920 B -29 B (3%)
jsx-runtime/dist/jsxRuntime.umd.js 1.03 kB -27 B (2%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.63 kB 0 B
debug/dist/debug.module.js 3.63 kB 0 B
debug/dist/debug.umd.js 3.71 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Apr 29, 2024 •
edited

Coverage Status

coverage: 99.609%. remained the same
when pulling c992f7e on move-default-props-to-compat
into 613cacc on main.

@JoviDeCroock JoviDeCroock changed the base branch from main to breaking-changes-11 April 30, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoviDeCroock @coveralls