debug: Disallow <tr> as a child of <table> #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10k
duration
usedJSHeapSize
filter-list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many-updates
duration
usedJSHeapSize
replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
update10th1k
duration
usedJSHeapSize
|
|
Size Change: -12 B (0%) Total Size: 61.2 kB
ℹ️ View Unchanged
|
rschristian
changed the title
JoviDeCroock
approved these changes
May 9, 2024
marvinhagemeister
approved these changes
May 9, 2024
Merged
robertknight
added a commit
to hypothesis/frontend-shared
that referenced
this pull request
May 20, 2024
The latest Preact release warns about `<tr>` elements that have a `<table>` as their direct parent. See preactjs/preact#4375.
robertknight
added a commit
to hypothesis/frontend-shared
that referenced
this pull request
May 20, 2024
The latest Preact release warns about `<tr>` elements that have a `<table>` as their direct parent. See preactjs/preact#4375.
robertknight
added a commit
to hypothesis/frontend-shared
that referenced
this pull request
May 20, 2024
The latest Preact release warns about `<tr>` elements that have a `<table>` as their direct parent. See preactjs/preact#4375.
robertknight
added a commit
to hypothesis/frontend-shared
that referenced
this pull request
May 20, 2024
The latest Preact release warns about `<tr>` elements that have a `<table>` as their direct parent. See preactjs/preact#4375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4111
Per the spec,
<tr>can be a child of<table>, but this is only because the spec also necessitates that parsers will wrap the<tr>in a<tbody>.Will see if MDN is willing to alter their wording here, as while the input is "allowed", it's just allowing devs to be a bit sloppy. It's not really valid.