test performance of reducing prototype access #4414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10k
duration
usedJSHeapSize
filter-list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many-updates
duration
usedJSHeapSize
replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
update10th1k
duration
usedJSHeapSize
|
JoviDeCroock
commented
Jun 19, 2024
| @@ -12,6 +12,7 @@ import { slice } from './util'; | |||
| * existing DOM tree rooted at `replaceNode` | |||
| */ | |||
| export function render(vnode, parentDom, replaceNode) { | |||
| setup(); | |||
There was a problem hiding this comment.
This would be needed to avoid us reaching into globals while we renderToStream or renderToString
|
Size Change: +289 B (+0.47%) Total Size: 62.1 kB
ℹ️ View Unchanged
|
|
Looks to be negligible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests whether we can give a minor performance boost with a size tradeoff by reducing prototype access, this currently breaks tests due to us not registering the calls anymore.