perf: do a single-pass babel transform for JSX and Hook Names #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 馃摉
This pull request moves the
babel-plugin-transform-hook-names
babel plugin to the main JSX transform, avoiding a double-pass Babel transform which is slower.Might want to review ignoring whitespace.
Potential Caveats鈿狅笍
Because now
esbuild
runs afterwards, types won't have been removed when the plugin runs.If a user uses the following syntax the name in devtools will be
memo: number
instead ofmemo
:However, it's not idiomatic usage, and the most common usage works as expected:
and in most cases the type would be auto-inferred from the initial value or expression.
fixes #34