Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom babel configuration #44

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

ps73
Copy link
Contributor

@ps73 ps73 commented Mar 4, 2022

I currently ran into an issue that legacy-decorators are not supported (same as #43) and I fixed it by adding the @babel/plugin-proposal-decorators and @babel/plugin-proposal-class-properties.

Unfortunately I had to inject these plugins directly into the packages source code. So I thought it would be nice to have an option to change babel config in vites config file.

@ps73
Copy link
Contributor Author

ps73 commented Mar 18, 2022

Hey @marvinhagemeister,

is there any option that this pull-request could be reviewed?

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks a bunch for the PR 👍

@marvinhagemeister marvinhagemeister merged commit 6b9f4d8 into preactjs:main Mar 29, 2022
@phiberber
Copy link

Hi, sorry to bring this to a Pull Request but I'd like to change the throwIfNamespace in the babel option, if this doesn't get much attention I'm going to create an issue by its own about it, just didn't want to pollute the issues board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants