Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .subscribe's type #137

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Fix .subscribe's type #137

merged 2 commits into from
Sep 13, 2022

Conversation

jviide
Copy link
Contributor

@jviide jviide commented Sep 13, 2022

Currently .subscribe()'s type is marked as subscribe(fn: (value: T) => () => void) (".subscribetakes a function that returns a function, .subscribe itself returns void").

This PR changes it to subscribe(fn: (value: T) => void): () => void (".subscribe takes a function, and .subscribe itself returns a function").

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022

🦋 Changeset detected

Latest commit: 4385ea8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 4385ea8
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6320f775e687a80009b3f3c7
😎 Deploy Preview https://deploy-preview-137--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jviide jviide marked this pull request as ready for review September 13, 2022 15:27
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I don't know how I could've gotten that wrong 🙈

@marvinhagemeister marvinhagemeister merged commit 4823f83 into preactjs:main Sep 13, 2022
@github-actions github-actions bot mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants