Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-transform] Support more component definitions & expand tests #441

Merged
merged 37 commits into from Nov 16, 2023

Conversation

andrewiggins
Copy link
Member

Add support for auto-transforming more ways to specify components: object methods, member assignments, export default components, components wrapped in HoCs like memo and forwardRef

Also expands the react transform test suite to generate test cases based on different combinations of syntaxes.

Since state should be a simple look up while reading name is an AST climb
Tests are failing cuz of bug :)
Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: ac06c35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react-transform Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit ac06c35
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/65556fe30acf120008a295ab
😎 Deploy Preview https://deploy-preview-441--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Size Change: +2.3 kB (+3%)

Total Size: 82.6 kB

Filename Size Change
packages/react-transform/dist/signals-*********.js 4.26 kB +765 B (+22%) 🚨
packages/react-transform/dist/signals-transform.mjs 3.57 kB +771 B (+28%) 🚨
packages/react-transform/dist/signals-transform.umd.js 4.37 kB +766 B (+21%) 🚨
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.9 kB
docs/dist/assets/index.********.js 833 B
docs/dist/assets/jsxRuntime.module.********.js 281 B
docs/dist/assets/preact.module.********.js 4.02 kB
docs/dist/assets/signals-core.module.********.js 1.46 kB
docs/dist/assets/signals.module.********.js 2.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.35 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 239 B
packages/core/dist/signals-core.js 1.54 kB
packages/core/dist/signals-core.mjs 1.56 kB
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB
packages/react/dist/signals.js 1.55 kB
packages/react/dist/signals.mjs 1.55 kB

compressed-size-action

@andrewiggins andrewiggins merged commit 4c433c3 into main Nov 16, 2023
6 checks passed
@andrewiggins andrewiggins deleted the improve-transform branch November 16, 2023 20:51
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants