Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto pkg & run react runtimes tests against auto & transform runtimes #443

Merged
merged 11 commits into from
Nov 21, 2023

Conversation

andrewiggins
Copy link
Member

Add auto package (not exported yet though) in preparation for next major release that will make auto runtime opt-in

Run @preact/signals-react test suite against test files using the auto and transform runtimes to verify each runtime's behavior.

Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: 907e043

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 907e043
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/655d2d2dc10ef30008cb660b
😎 Deploy Preview https://deploy-preview-443--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 20, 2023

Size Change: -470 B (-1%)

Total Size: 83.6 kB

Filename Size Change
docs/dist/assets/client.********.js 46.8 kB -145 B (0%)
packages/react/dist/signals.js 1.43 kB -115 B (-7%)
packages/react/dist/signals.mjs 1.34 kB -210 B (-14%) 👏
ℹ️ View Unchanged
Filename Size
docs/dist/assets/index.********.js 833 B
docs/dist/assets/jsxRuntime.module.********.js 281 B
docs/dist/assets/preact.module.********.js 4.02 kB
docs/dist/assets/signals-core.module.********.js 1.46 kB
docs/dist/assets/signals.module.********.js 2.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.35 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 239 B
packages/core/dist/signals-core.js 1.54 kB
packages/core/dist/signals-core.mjs 1.56 kB
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB
packages/react-transform/dist/signals-*********.js 4.77 kB
packages/react-transform/dist/signals-transform.mjs 4.02 kB
packages/react-transform/dist/signals-transform.umd.js 4.88 kB

compressed-size-action

Comment on lines -11 to -12
import { useSignal, useComputed, useSignalEffect } from "../runtime";
import { installAutoSignalTracking } from "../runtime/src/auto";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This double import caused some duplicate code in the final bundle. Combining them is what caused this PR to reduce the overall bundle size shown in the size-bot comment.

@andrewiggins andrewiggins merged commit 020982d into main Nov 21, 2023
6 checks passed
@andrewiggins andrewiggins deleted the auto-pkg branch November 21, 2023 22:35
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants