Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use function expression name if it has one #446

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Nov 23, 2023

Component's like

var render = function App() { ... }

will now by transformed by the babel plugin since the function expression has a valid Component name.

Before it would not be transformed because the variable name was not valid because the variable name begins with a lowercase letter.

Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: ca716b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react-transform Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit ca716b3
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/655f170ad5c27700083fd7a9
😎 Deploy Preview https://deploy-preview-446--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Size Change: +12 B (0%)

Total Size: 83.9 kB

Filename Size Change
packages/react-transform/dist/signals-*********.js 4.77 kB +4 B (0%)
packages/react-transform/dist/signals-transform.mjs 4.02 kB +4 B (0%)
packages/react-transform/dist/signals-transform.umd.js 4.88 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.8 kB
docs/dist/assets/index.********.js 1.07 kB
docs/dist/assets/jsxRuntime.module.********.js 281 B
docs/dist/assets/preact.module.********.js 4.02 kB
docs/dist/assets/signals-core.module.********.js 1.46 kB
docs/dist/assets/signals.module.********.js 2.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.41 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 239 B
packages/core/dist/signals-core.js 1.54 kB
packages/core/dist/signals-core.mjs 1.56 kB
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB
packages/react/dist/signals.js 1.43 kB
packages/react/dist/signals.mjs 1.34 kB

compressed-size-action

@andrewiggins andrewiggins merged commit 09f3ed7 into main Nov 23, 2023
6 checks passed
@andrewiggins andrewiggins deleted the fix-transform-tests branch November 23, 2023 09:14
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants