Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typescript error from resolving unspecified in exports map .ts file #456

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

XantreDev
Copy link
Contributor

Should fix: #450

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: deb0111

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit deb0111
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/656769ca4e8401000816f6f4
😎 Deploy Preview https://deploy-preview-456--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, let me know if you're good w/ having this merged as it's still set to be a draft

@XantreDev XantreDev marked this pull request as ready for review November 29, 2023 16:34
@XantreDev
Copy link
Contributor Author

Since @paul-sachs confirmed this is working - undrafted

@rschristian rschristian reopened this Nov 29, 2023
@rschristian
Copy link
Member

Sorry for the close & reopen, the CI seemingly got stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signals-react: Wrong import path in dist/signals.d.ts causing TypeScript errors
2 participants