Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mixing useSignals called in hooks and components together #459

Merged
merged 24 commits into from
Dec 5, 2023

Conversation

andrewiggins
Copy link
Member

This PR adds tests and supported for nested useSignals calls when combined in components & hooks. We generally have two different mechanisms to call useSignals: 1) using react-transform & 2) calling useSignals() directly in a component or hook.

To support mixing and matching these scenarios, I've added parameter to useSignals() that specifies how this invocation is being used. It primarily exists for the transform to tell useSignals it is gonna be manually closed by the code the transform emits.

Using this parameter, when I new store starts, it can examine the previous store and properly handle closing it out or "capture and restoring it" once the current store finishes. See the comment in runtime/src/index.ts:_start() for a detailed description of the exact behavior here.

Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: cb7c2a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react-transform Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit cb7c2a3
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/656e6d959764990008cf5287
😎 Deploy Preview https://deploy-preview-459--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Size Change: -42 B (0%)

Total Size: 84.1 kB

Filename Size Change
docs/dist/assets/client.********.js 46.8 kB +27 B (0%)
docs/dist/react-********.js 238 B -2 B (-1%)
packages/react-transform/dist/signals-*********.js 4.75 kB -85 B (-2%)
packages/react-transform/dist/signals-transform.mjs 4 kB -85 B (-2%)
packages/react-transform/dist/signals-transform.umd.js 4.87 kB -82 B (-2%)
packages/react/dist/signals.js 1.52 kB +91 B (+6%) 🔍
packages/react/dist/signals.mjs 1.49 kB +94 B (+7%) 🔍
ℹ️ View Unchanged
Filename Size
docs/dist/assets/index.********.js 1.07 kB
docs/dist/assets/jsxRuntime.module.********.js 281 B
docs/dist/assets/preact.module.********.js 4.02 kB
docs/dist/assets/signals-core.module.********.js 1.46 kB
docs/dist/assets/signals.module.********.js 2.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.41 kB
docs/dist/nesting-********.js 1.13 kB
packages/core/dist/signals-core.js 1.54 kB
packages/core/dist/signals-core.mjs 1.56 kB
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB

compressed-size-action

@andrewiggins andrewiggins merged commit 06d4c10 into main Dec 5, 2023
6 checks passed
@andrewiggins andrewiggins deleted the fix-signal-text-2 branch December 5, 2023 19:52
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants