Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document effect cleanups & comment why ES5-style prototypes are used #529

Merged
merged 3 commits into from Mar 15, 2024

Conversation

jviide
Copy link
Contributor

@jviide jviide commented Mar 15, 2024

This pull request adds minor bits of documentation.

  • Add a comment to the source code why ES5-style prototypes are used instead of ES6-style classes.
  • Add documentation mentioning effect cleanups in README.md.
  • Fix README.md's section order that was not in sync with the table of contents in the beginning of README.md.

Copy link

changeset-bot bot commented Mar 15, 2024

⚠️ No Changeset found

Latest commit: 590a466

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 590a466
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/65f472dfdd10180008e1cda5
😎 Deploy Preview https://deploy-preview-529--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@marvinhagemeister marvinhagemeister merged commit ec5fe42 into preactjs:main Mar 15, 2024
6 checks passed
@jviide jviide deleted the docs branch March 15, 2024 16:17
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants