only set mediaTypes.banner.sizes from sizes if mediaTypes doesn't exi…

…st. (#3274) fixed #3269
prebid · Nov 15, 2018 · 186ee66 · 186ee66
1 parent 8f53dca
commit 186ee66
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/src/sizeMapping.js b/src/sizeMapping.js
@@ -65,22 +65,20 @@ export function resolveStatus({labels = [], labelAll = false, activeLabels = []}
   let maps = evaluateSizeConfig(configs);
 
   if (!isPlainObject(mediaTypes)) {
-    mediaTypes = {};
+    // add support for deprecated adUnit.sizes by creating correct banner mediaTypes if they don't already exist
+    if (sizes) {
+      mediaTypes = {
+        banner: {
+          sizes
+        }
+      };
+    } else {
+      mediaTypes = {};
+    }
   } else {
     mediaTypes = deepClone(mediaTypes);
   }
 
-  // add support for deprecated adUnit.sizes by creating correct banner mediaTypes if they don't already exist
-  if (sizes) {
-    if (!mediaTypes.banner) {
-      mediaTypes.banner = {
-        sizes
-      }
-    } else if (!mediaTypes.banner.sizes) {
-      mediaTypes.banner.sizes = sizes;
-    }
-  }
-
   let oldSizes = deepAccess(mediaTypes, 'banner.sizes');
   if (maps.shouldFilter && oldSizes) {
     mediaTypes.banner.sizes = oldSizes.filter(size => maps.sizesSupported[size]);