reading battr from ortb2Imp.banner

prebid · Jul 4, 2024 · cb85e20 · cb85e20
1 parent 74330a8
commit cb85e20
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/modules/pubmaticBidAdapter.js b/modules/pubmaticBidAdapter.js
@@ -557,8 +557,8 @@ function _createBannerRequest(bid) {
     bannerObj.topframe = inIframe() ? 0 : 1;
 
     // Adding Banner custom params
+    const bannerCustomParams = {...deepAccess(bid, 'ortb2Imp.banner')};
     for (let key in BANNER_CUSTOM_PARAMS) {
-      let bannerCustomParams = bid.mediaTypes.banner;
       if (bannerCustomParams.hasOwnProperty(key)) {
         bannerObj[key] = _checkParamDataType(key, bannerCustomParams[key], BANNER_CUSTOM_PARAMS[key]);
       }

diff --git a/test/spec/modules/pubmaticBidAdapter_spec.js b/test/spec/modules/pubmaticBidAdapter_spec.js
@@ -4086,10 +4086,10 @@ describe('PubMatic adapter', function () {
     }
 
     describe('Banner Request param battr checking', function() {
-      it('should add battr params to bannerObj if present in mediaTypes.banner', function() {
+      it('should add battr params to bannerObj if present in ortb2Imp.banner', function() {
         let originalBidRequests = utils.deepClone(bidRequests);
-        let bannerObj = utils.deepClone(originalBidRequests[0].mediaTypes.banner);
-        originalBidRequests[0].mediaTypes.banner = Object.assign(bannerObj, {
+        let bannerObj = utils.deepClone(originalBidRequests[0].ortb2Imp.banner);
+        originalBidRequests[0].ortb2Imp.banner = Object.assign(bannerObj, {
           battr: [1, 2]
         });
 
@@ -4098,11 +4098,11 @@ describe('PubMatic adapter', function () {
         });
         let data = JSON.parse(req.data);
         expect(data.imp[0]['banner']['battr']).to.exist.and.to.be.an('array');
-        expect(data.imp[0]['banner']['battr'][0]).to.equal(originalBidRequests[0].mediaTypes.banner['battr'][0]);
-        expect(data.imp[0]['banner']['battr'][1]).to.equal(originalBidRequests[0].mediaTypes.banner['battr'][1]);
+        expect(data.imp[0]['banner']['battr'][0]).to.equal(originalBidRequests[0].ortb2Imp.banner['battr'][0]);
+        expect(data.imp[0]['banner']['battr'][1]).to.equal(originalBidRequests[0].ortb2Imp.banner['battr'][1]);
       });
 
-      it('should not add battr params to bannerObj if not present in mediaTypes.banner', function() {
+      it('should not add battr params to bannerObj if not present in ortb2Imp.banner', function() {
         const req = spec.buildRequests(bidRequests, {
           auctionId: 'new-auction-id'
         });
@@ -4112,8 +4112,8 @@ describe('PubMatic adapter', function () {
 
       it('should not add battr params if _checkParamDataType returns undefined (Mismatch data type)', function() {
         let originalBidRequests = utils.deepClone(bidRequests);
-        let bannerObj = utils.deepClone(originalBidRequests[0].mediaTypes.banner);
-        originalBidRequests[0].mediaTypes.banner = Object.assign(bannerObj, {
+        let bannerObj = utils.deepClone(originalBidRequests[0].ortb2Imp.banner);
+        originalBidRequests[0].ortb2Imp.banner = Object.assign(bannerObj, {
           battr: 1
         });