BugFix UserID module refreshUserIds

prebid · Jun 28, 2021 · ce953c9 · ce953c9
1 parent 19e8f52
commit ce953c9
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 0 deletions.
diff --git a/modules/userId/index.js b/modules/userId/index.js
@@ -613,6 +613,11 @@ function refreshUserIds(options, callback) {
 
       utils.logInfo(`${MODULE_NAME} - refreshing ${submodule.submodule.name}`);
       populateSubmoduleId(submodule, consentData, storedConsentData, true);
+      updateInitializedSubmodules(submodule);
+
+      if (initializedSubmodules.length) {
+        setPrebidServerEidPermissions(initializedSubmodules);
+      }
 
       if (utils.isFn(submodule.callback)) {
         callbackSubmodules.push(submodule);
@@ -711,6 +716,20 @@ function initSubmodules(submodules, consentData) {
   }, []);
 }
 
+function updateInitializedSubmodules(submodule) {
+  let updated = false;
+  for (let i = 0; i < initializedSubmodules.length; i++) {
+    if (submodule.config.name.toLowerCase() === initializedSubmodules[i].config.name.toLowerCase()) {
+      updated = true;
+      initializedSubmodules[i] = submodule;
+    }
+  }
+
+  if (!updated) {
+    initializedSubmodules.push(submodule);
+  }
+}
+
 /**
  * list of submodule configurations with valid 'storage' or 'value' obj definitions
  * * storage config: contains values for storing/retrieving User ID data in browser storage

diff --git a/test/spec/modules/userId_spec.js b/test/spec/modules/userId_spec.js
@@ -365,6 +365,46 @@ describe('User ID', function () {
       expect(mockIdCallback.callCount).to.equal(1);
     });
 
+    it('pbjs.refreshUserIds updates submodules', function() {
+      let sandbox = sinon.createSandbox();
+      let mockIdCallback = sandbox.stub().returns({id: {'MOCKID': '1111'}});
+      let mockIdSystem = {
+        name: 'mockId',
+        decode: function(value) {
+          return {
+            'mid': value['MOCKID']
+          };
+        },
+        getId: mockIdCallback
+      };
+      setSubmoduleRegistry([mockIdSystem]);
+      init(config);
+      config.setConfig({
+        userSync: {
+          syncDelay: 0,
+          userIds: [{
+            name: 'mockId',
+            value: {id: {mockId: '1111'}}
+          }]
+        }
+      });
+
+      expect(getGlobal().getUserIds().id.mockId).to.equal('1111');
+
+      // update to new config value
+      config.setConfig({
+        userSync: {
+          syncDelay: 0,
+          userIds: [{
+            name: 'mockId',
+            value: {id: {mockId: '1212'}}
+          }]
+        }
+      });
+      getGlobal().refreshUserIds({ submoduleNames: ['mockId'] });
+      expect(getGlobal().getUserIds().id.mockId).to.equal('1212');
+    });
+
     it('pbjs.refreshUserIds refreshes single', function() {
       coreStorage.setCookie('MOCKID', '', EXPIRED_COOKIE_DATE);
       coreStorage.setCookie('REFRESH', '', EXPIRED_COOKIE_DATE);