Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to assign 1 set of creatives to all line items in DFP #21

Closed
Heray opened this issue Aug 13, 2015 · 0 comments
Closed

Document how to assign 1 set of creatives to all line items in DFP #21

Heray opened this issue Aug 13, 2015 · 0 comments

Comments

@Heray
Copy link

Heray commented Aug 13, 2015

No description provided.

@prebid prebid closed this as completed Dec 1, 2015
marian-r referenced this issue in aol/Prebid.js Sep 23, 2016
@marian-r
Merge pull request #21 in AOLP_ADS_JS/prebid.js from release/1.0.6 to…
5d0c788 
… master

* commit '8d3bf4dfde3f6fbf456c336dd0e75132f9c203de':
  Version bumped to 1.0.6
  Limit action ID max digits to 18, in order to prevent value exceeding 64 bits.
lntho referenced this issue in openx/Prebid.js Oct 11, 2016
Merge pull request #21 from header-bidder/APPS-12871
8507f55 
chore(ci): Refactor openx-neo adapter
kd-appier pushed a commit to appier/Prebid.js that referenced this issue May 30, 2019
@yhhuang-appier
Merged in yhhuang@avoid-using-for-of-to-support-ie11 (pull request pr…
ddb3373 
…ebid#21)

replace for...of by array.forEach for IE11

Approved-by: kdchang_appier <kd.chang@appier.com>
robertrmartinez pushed a commit that referenced this issue Apr 21, 2020
@SublimeLeo @hellsingblack @fgcloutier
SublimeBidAdapter: Update to version 0.5.1 (#4977)
6311c46 
* add prebid version of adapter

* Feature/update sublime adapter (#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (#22)

* add prebid version of adapter
* Feature/update sublime adapter (#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this issue Jun 22, 2020
@SublimeLeo @hellsingblack
@fgcloutier @iggyfisk
SublimeBidAdapter: Update to version 0.5.1 (prebid#4977)
1b622d3 
* add prebid version of adapter

* Feature/update sublime adapter (prebid#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (prebid#22)

* add prebid version of adapter
* Feature/update sublime adapter (prebid#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
coreykress pushed a commit to coreykress/Prebid.js that referenced this issue Aug 26, 2020
Merge pull request prebid#21 in SA/prebid from CAP-1966 to master
21cf18f 
* commit '74f7c5859c1bdb465fd781b900b1ec0319638f90':
  CAP-1966: Set hostname based on seat
  CAP-1966: Fix video impid parsing
harpere pushed a commit that referenced this issue Mar 19, 2021
@JeremiePat @hellsingblack
@SublimeLeo @fgcloutier
Sublime Bid Adapter: v0.7.1 & add extra information in tracking pixels (
81a9e2b 
#6442)

* add prebid version of adapter

* Feature/update sublime adapter (#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (#22)

* add prebid version of adapter
* Feature/update sublime adapter (#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

* sublimeAdapter: Improve pixels data

* sublimeAdapter: Update tests

* sublimeAdapter: Rename data

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: Léo <51166933+SublimeLeo@users.noreply.github.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Léo GRAND <leo.grand@sublimeskinz.com>
seergiioo6 pushed a commit to seergiioo6/Prebid.js that referenced this issue Mar 23, 2021
@JeremiePat @hellsingblack
@SublimeLeo @fgcloutier @seergiioo6
Sublime Bid Adapter: v0.7.1 & add extra information in tracking pixels (
f0db266 
prebid#6442)

* add prebid version of adapter

* Feature/update sublime adapter (prebid#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (prebid#22)

* add prebid version of adapter
* Feature/update sublime adapter (prebid#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

* sublimeAdapter: Improve pixels data

* sublimeAdapter: Update tests

* sublimeAdapter: Rename data

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: Léo <51166933+SublimeLeo@users.noreply.github.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Léo GRAND <leo.grand@sublimeskinz.com>
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this issue May 28, 2021
@JeremiePat @hellsingblack
@SublimeLeo @fgcloutier @stsepelin
Sublime Bid Adapter: v0.7.1 & add extra information in tracking pixels (
c895280 
prebid#6442)

* add prebid version of adapter

* Feature/update sublime adapter (prebid#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (prebid#22)

* add prebid version of adapter
* Feature/update sublime adapter (prebid#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

* sublimeAdapter: Improve pixels data

* sublimeAdapter: Update tests

* sublimeAdapter: Rename data

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: Léo <51166933+SublimeLeo@users.noreply.github.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Léo GRAND <leo.grand@sublimeskinz.com>
This was referenced Jul 8, 2021
Closed
Closed
@snyk-bot snyk-bot mentioned this issue Aug 9, 2022
Open
patmmccann pushed a commit that referenced this issue Jul 12, 2023
@juliangan07 @jsadwith
Kargo Bid Adapter: Forward schain in the request (#10202)
361cf62 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

---------

Co-authored-by: Jeremy Sadwith <jeremy@kargo.com>
ChrisHuie pushed a commit that referenced this issue Oct 10, 2023
@njflynn @jsadwith @juliangan07
Kargo Bid Adapter: adding site to Kargo adapter (#10589)
1a40e59 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

* Adding site to Kargo adapter.

* KRKPD-619 Updating Site object.

* KRKPD-619 Adding null check for  Site object.

* Update modules/kargoBidAdapter.js

Co-authored-by: Julian Gan  <juliangan07@gmail.com>

* Reducing the size of Site object.

* remove white space that is causing linting error

---------

Co-authored-by: Jeremy Sadwith <jeremy@kargo.com>
Co-authored-by: Julian Gan <juliangan07@gmail.com>
patmmccann pushed a commit that referenced this issue Oct 17, 2023
@jsadwith @juliangan07 @njflynn
Kargo Bid Adapter: Updates to GPID retrieval (#10618)
665f356 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

* Adding site to Kargo adapter.

* KRKPD-619 Updating Site object.

* KRKPD-619 Adding null check for  Site object.

* Update modules/kargoBidAdapter.js

Co-authored-by: Julian Gan  <juliangan07@gmail.com>

* Reducing the size of Site object.

* remove white space that is causing linting error

* Kargo Bid Adapter: Updates to gpid retrieval

---------

Co-authored-by: Julian Gan <juliangan07@gmail.com>
Co-authored-by: Neil Flynn <nflynn@kargo.com>
ChrisHuie pushed a commit that referenced this issue Oct 30, 2023
@jsadwith @juliangan07 @njflynn
Kargo Bid Adapter: Support for sending ortb2.user.data (#10659)
a94f7f0 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

* Adding site to Kargo adapter.

* KRKPD-619 Updating Site object.

* KRKPD-619 Adding null check for  Site object.

* Update modules/kargoBidAdapter.js

Co-authored-by: Julian Gan  <juliangan07@gmail.com>

* Reducing the size of Site object.

* remove white space that is causing linting error

* Kargo Bid Adapter: Updates to gpid retrieval

* Support for sending ortb2.user.data

---------

Co-authored-by: Julian Gan <juliangan07@gmail.com>
Co-authored-by: Neil Flynn <nflynn@kargo.com>
Fawke pushed a commit that referenced this issue Mar 14, 2024
@sj1815 @jsadwith
@juliangan07 @njflynn @nickllerandi
Kargo Bid Adapter: floors and CreativeID update (#11153)
77254c2 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

* Adding site to Kargo adapter.

* KRKPD-619 Updating Site object.

* KRKPD-619 Adding null check for  Site object.

* Update modules/kargoBidAdapter.js

Co-authored-by: Julian Gan  <juliangan07@gmail.com>

* Reducing the size of Site object.

* remove white space that is causing linting error

* Kargo Bid Adapter: Updates to gpid retrieval

* Support for sending ortb2.user.data

* update bid Response to use actual creativeID

* update spec

* fix nomencalature based on Kargo's service

* Prebid.js - Update bid Response to use actual creativeID (#25)

* update bid Response to use actual creativeID

* update spec

* fix nomencalature based on Kargo's service

* utilize floors mod

* fixes tests

* mediatype specific floors

* simpler implementation leveraging Prebid's smart rule selection

* revert nomenclature change

* fix

* removes comment

---------

Co-authored-by: Jeremy Sadwith <jeremy@kargo.com>
Co-authored-by: Julian Gan <juliangan07@gmail.com>
Co-authored-by: Neil Flynn <nflynn@kargo.com>
Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
Co-authored-by: Nick Llerandi <nick.llerandi@kargo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Heray