Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ix/indexExchange ignores unit if media type is not set #2574

Closed
dmitriyshashkin opened this Issue May 19, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@dmitriyshashkin
Copy link
Contributor

dmitriyshashkin commented May 19, 2018

Type of issue

Bug

Description

According to the docs, media type field for ad unit is optional. Yet ixBidAdapter expects it to bet, otherwise, it just ignores that banner. Seen a major drop in impressions since updated to 1.x

if (utils.deepAccess(validBidRequest, 'mediaTypes.banner') ||
        validBidRequest.mediaType === 'banner') {
        bannerImp = bidToBannerImp(validBidRequest);
        bannerImps.push(bannerImp);
}

Steps to reproduce

Create an ad unit, add ix to bidders, do not specify the media type.

Test page

Expected results

Index competes for the impression

Actual results

Index excludes this unit from bid request. "Imp" field in https request to cygnus server is empty

Platform details

Prebid 1.11

@jaiminpanchal27

This comment has been minimized.

Copy link
Collaborator

jaiminpanchal27 commented May 21, 2018

@dmitriyshashkin Not able to reproduce. Here is the test page https://jsfiddle.net/8z103Lpc/
I can see the call to http://as.casalemedia.com/cygnus... and get {id: "3cf1af3371e3d4"} as response.

@rachelrj

This comment has been minimized.

Copy link
Contributor

rachelrj commented May 21, 2018

This happens with us as well. Also if the size is not set as a param (bidder param), will error out.

@rachelrj

This comment has been minimized.

Copy link
Contributor

rachelrj commented May 21, 2018

There should also be some sort of communication that siteID changed to sideId. This has been a major issue for upgrades.

@aprakash-sovrn

This comment has been minimized.

Copy link
Contributor

aprakash-sovrn commented May 21, 2018

Hi @jaiminpanchal27,
It doesn't look like prebid.js is loading on your fiddle, I get a 404 on the call to https://fiddle.jshell.net/build/dev/prebid.js. Also, I believe the call to http://as.casalemedia.com/cygnus... is still made when the mediaTypes object is excluded, but with an empty imp array (as the code snippet pointed out by @dmitriyshashkin skips adding the bid to the imp array without that field), which is the issue.

The size as a bidder param is also an interesting change. Is the publisher only allowed to specify one size in bid requests to ix now?

@ptim

This comment has been minimized.

Copy link
Contributor

ptim commented May 23, 2018

regarding @rachelrj 's and @aprakash-sovrn's comments about size - I found the docs ambiguous, and opened an issue over here: #2590

I think (hope) the docs might have a typo

@ptim ptim referenced this issue May 23, 2018

Merged

Update ixBidAdapter.md #2598

2 of 9 tasks complete
@aprakash-sovrn

This comment has been minimized.

Copy link
Contributor

aprakash-sovrn commented May 23, 2018

@ix-prebid-support, are you able to shed light on some of these issues?

@stale

This comment has been minimized.

Copy link

stale bot commented Jun 6, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.