-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid 1.0.0 Proposal - intent to implement #891
Comments
I've received a few questions on on how to submit feedback, so posting here: Q) What's the best way to submit feedback? Q) What is the formal process for getting changes into the spec? Q) What's the detailed design for Prebid 1.0? |
That's great news that Prebid.JS is finally achieving the 1.0 milestone! I bet many publishers are observing what we are trying to do with header bidding, and are waiting for Prebid.JS to stabilize before proceeding to implementing it. Reaching the “golden” 1.0 version will certainly help a much broader use of this technology. I have a few remarks to the initial draft, as Matt suggested, I am going to comment this issue directly. As some of you already know, I work at Piximedia, which is a French-originating advertising technology company. We are specialized in rich media ads, and are displaying contents mainly in the EMEA market. Most, if not all, of our remarks are a consequence of us using the Prebid framework to display not only IAB display ads, but also various rich-media ads.
Once again, thank you everyone for your work! Let me know what you think of our remarks. All the best, |
Proposal has been updated. |
How do you reconcile these two statements?
And
My understanding is that PreBid reserves the right to phone home from a given client, which is, in essence, analytics. I am all for gathering data across the ecosystem about performance, though I would say:
|
@pdezwart |
Community update: the Prebid Org team is now focused on the 1.0 release as described above. The focus of 1.0 is performance and refactoring the modularity. You'll have noticed the 7 sub-issues opened to track the work being done -- they will be fleshed out in the coming weeks. The goal is to get a spec out to adapter owners in the next month so they have time to make any necessary modifications, with the aim of releasing the upgrade this summer. We will do our best to accommodate any further feedback from the community. |
@bretg Thanks for all your work. We were writing our adapter, then we saw v1.0 was announced, so we are now making the required changes. Where can we find the full spec? |
@thewizarodofoz |
@mkendall07 Thanks, I'm familiar with this. What I'm missing is the internal models which are passed to adapter methods like the {
"bidder": "example",
"bidId": "51ef8751f9aead",
"params": {
},
"adUnitCode": "div-gpt-ad-1460505748561-0",
"transactionId": "d7b773de-ceaa-484d-89ca-d9f51b8d61ec",
"sizes": [
[
320,
50
],
[
300,
250
],
[
300,
600
]
],
"bidderRequestId": "418b37f85e772c",
"auctionId": "18fd8b8b0bd757"
} |
Is there any way to test a 1.0 prerelease version? |
@therazor You can use Prebid-1.0 branch for testing. We are doing all 1.0 related stuff in this branch. |
@jaiminpanchal27 I saw that branch, but it seems like there is only one bidder adapter - not enough for testing. |
@therazor Yes that branch will only have Prebid-1.0 compliant adapters. We updated Pulsepoint udpated their adapter #1338, that will be reviewed and merged soon. As @mkendall07 said in his 1.0 blog post, We need your help to work with Prebid 1.0. We are hoping that everybody will pitch in. |
In order to start working on 1.0 version support- |
@PWyrembak the specific compression format doesn't matter. All that matters is that you support compression on the response based on what the client sends in the standard http header We cannot guarantee what a client sends, that's up to each individual browser, agent etc. |
@mkendall07 thank you, your answer makes sense. |
@mkendall07 In order to make sure we're on the same page. Should we treat Accept-Encoding: gzip same was as Accept-Encoding: deflate and return gzipped header bids in both cases? |
And @mkendall07 another confirmation. In case of header nobid we will return a simple empty JSON '{}' which is not gzipped. It doesn't seem reasonable to gzip such nobid answer though. Could you please confirm this will work as expected on your end? |
@mkendall07 Regarding currency support, I saw that this currency note:
is under "Recommendations" not "Requirements." But, reading through this: #1089 one of the notes is:
Would this mean that if a bidder sends in region based bids (eg. bids in EUR or GBP for EMEA pubs) that the adapter would be required to have currency support or else would be at risk of defaulting their bids to USD? |
That's correct. I updated the doc accordingly. |
@bwoolcott - just to be clear, as long as the adapter knows which currency the bid is in and can report it in the bidResponse, it doesn't necessarily need to take in the page's requested currency. The client-based currency conversion will be able to convert so long as it knows what it's working with. e.g. say the page (and ad server) wants "EUR", but the bidder sees that the user is in the UK so bids in GBP. As long as the adapter puts GPB in the bidResponse, it will get properly converted to EUR before being sent to the ad server. |
@mkendall07 regarding 'ttl' parameter: |
Prebid 1.0 released -- http://prebid.org/blog/prebid-1-is-released |
Please see http://prebid.org/dev-docs/bidder-adaptor.html for the latest adapter requirements. Some of the information below is out of date
Updates
Type of issue
Intent to implement. Open for comment.
Background and Motivation
To this point, Prebid.js releases have been iterating on major version 0 (as of the time of writing, the latest Prebid.js release is 0.18.0). Given the maturity and widespread adoption of Prebid.js, we are approaching the point at which we should start pushing towards release of version 1.0.0.
In traditional semantic software versioning, version 0.X.X implies beta software in which large public API changes should be expected. Version 1.X.X implies stabilization of public APIs (i.e. major breaking changes should no longer be expected).
The release of Prebid.js version 1.0.0 gives us the opportunity to take a firmer stance on adaptor standardization and performance, on which Prebid has been intentionally lax. To this effect, the requirements and recommendations outlined below represent a fundamental paradigm shift for Prebid.js, whereby we decide that regulation of adapter behavior, security, and page performance are in-scope.
We encourage the community to review the following proposal and offer comments and suggestions to further shape this document.
Prebid 1.0.0 Summary
Based on frequently recurring suggestions from the Prebid.js user base, the Prebid core team has identified the following high-level themes on which we aim to focus with the release of Prebid.js version 1.0.0:
Performance
Core
requestBids
for one or more adUnits.Source
object, this impression ID may be shared across multiple exchanges.Adapters
Requirements
requestBids
will generate a unique auction ID. All adapters must return this unique auction ID on all bid responses.Recommendations
Security
window.top
access) and must support transmission over PostMessage APIDesign
Key Considerations
Modularity
Note: The use of "Sub module" here doesn't necessarily mean a git submodule. We are considering a a Monorepo type structure (https://github.com/babel/babel/blob/master/doc/design/monorepo.md)
Configuration Driven
Enforcement
Browser Support
Other information
@prebid/core
@prebid/prebid-bidder-adaptors
@bretg
@snapwich
The text was updated successfully, but these errors were encountered: