Legacy native implementation: why is aspect_ratios set to an object in fromOrtbNativeRequest?

[msmeza]

Type of issue

Question

Description

In the function fromOrtbNativeRequest in native.js, img.aspect_ratios is set to an object, but a global search for aspect_ratios in this repository shows that most occurrences are expected to be of type array. Why is aspect_ratios set to an object and not an array in fromOrtbNativeRequest?

[dgirardi]

I believe this is simply a bug (paging @musikele just in case you disagree)

[musikele]

This is what can be found in previous documentation:

Then, in the example, it is an array:

Honestly i don't remember what pushed me to treat as an object. Probably unit tests, or probably the fact that in ORTB you cannot specify multiple aspect ratios...