Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: fix aspect_ratios in ortb -> legacy native asset conversion #9923

Merged
merged 1 commit into from
May 22, 2023

Conversation

dgirardi
Copy link
Collaborator

@dgirardi dgirardi commented May 9, 2023

Type of change

  • Bugfix

Description of change

Fixes #9922

@dgirardi dgirardi changed the title Core: fix in ortb -> legacy native asset conversion Core: fix aspect_ratios in ortb -> legacy native asset conversion May 9, 2023
@ChrisHuie ChrisHuie requested a review from Rothalack May 10, 2023 12:00
Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working, looks good to me.

@patmmccann patmmccann merged commit 5ac6dcc into prebid:master May 22, 2023
2 checks passed
mscottnelson added a commit to 33Across/Prebid.js that referenced this pull request Jun 2, 2023
* 33across_analytics_adapter:
  Adman Adapter: remove useless parameter (prebid#9967)
  Rise Bid Adapter: support sua and plcmt params. (prebid#9996)
  clean.io RTD Module: Use loadExternalScript function instead of insertElement() method to insert the Clean.io script. (prebid#9991)
  Bump socket.io-parser from 4.2.1 to 4.2.3 (prebid#9992)
  AdHash Bid Adapter: changes to support preroll videos (prebid#9870)
  RTB House Bid Adapter: docs update - FLEDGE support (prebid#9986)
  Core: fix  in ortb -> legacy native asset conversion (prebid#9923)
  Adnuntius Bid Adaptor: Handling deals better (prebid#9943)
  FreeWheel SSP Adapter: add support for video.plcmt (prebid#9978)
  PubMatic Bid Adapter: Added support for video.plcmt (prebid#9979)
  Criteo Bid Adapter: add support for video.plcmt (prebid#9975)
  add SSP Copper6 alias adapter (prebid#9972)
  Criteo bid adapter: Add video outstream renderer (prebid#9955)
  PBS Bid Adapter: add context to emitted seatnonbid event (prebid#9804)
  GumGum Bid Adapter : Id5 integration suppress link type for ttd (prebid#9924)
  Increment version to 7.51.0-pre
  Prebid 7.50.0 release
  Docs Integration Examples : add Events UI page for Video Module  (prebid#9934)
  LiveIntent UserId module: add support for distributorId configuration parameter (prebid#9963)
  Underdog Media Bid Adapter: Update ttl & referer information (prebid#9826)
  eps_aliasing - adding in aliases for epsilon (formerly conversant) for bidder and analytics (prebid#9961)
  Add mobile client hint 33x adapter (prebid#9958)
  confiant Rtd Provider : add message type check (prebid#9950)
  Criteo Bid Adapter: add support for imp.rwdd (prebid#9964)
  Yahoo SSP adapter support for extra site publisher info. (prebid#9921)
  RubiconBidAdapter: sync parseSize algorithm for isBidRequestValid and ortb conversion (prebid#9957)

Ticket: IDG-829
musikele pushed a commit to rubicon-project/Prebid.js that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy native implementation: why is aspect_ratios set to an object in fromOrtbNativeRequest?
5 participants