Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXKulture Bid Adapter: implementing ORTB conversion library #10584

Merged

Conversation

kmdevops
Copy link
Contributor

@kmdevops kmdevops commented Oct 6, 2023

Type of change

  • Bugfix

  • [x ] Feature

  • New bidder adapter

  • [x ] Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Implementing and using Prebid.js library that provides methods to convert Prebid.js bid request objects to ORTB requests, and ORTB responses to Prebid.js bid response objects.

Other information

  • Adapter has been updated according to the documentation described at the official page Prebid.js - ORTB conversion library
  • Refactored all tests in the part related to the correct use of the ortb converter library
  • Removing the networkId parameter
  • Introducing optional bidfloor and bidfloorcur parameters

@ncolletti ncolletti self-assigned this Oct 9, 2023
@ncolletti
Copy link
Contributor

docs pr: prebid/prebid.github.io#4797

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ncolletti ncolletti added the LGTM label Oct 20, 2023
@ncolletti ncolletti merged commit b4296cd into prebid:master Oct 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants