Tead Bid Adapter: support ad slot name in code parameter of ad unit #10825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
approved these changes
Dec 12, 2023
ChrisHuie
added a commit
that referenced
this pull request
Dec 12, 2023
This reverts commit 947a487.
ChrisHuie
added a commit
that referenced
this pull request
Dec 12, 2023
aecook
pushed a commit
to freestarcapital/Prebid.js
that referenced
this pull request
Jan 17, 2024
* Increment version to 8.28.0-pre * Support UID 2.0 pgamssp module (prebid#10771) * new adapter PGAMSSP * upd * support UID 2.0 * del obj * ADSS-1756-pass-gpid-to-video-requests (prebid#10809) Co-authored-by: John Bauzon <john.bauzon@gumgum.com> * Browsi RTD : fix for targeting (prebid#10814) * real time data module, browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe * change timeout&primary ad server only to auctionDelay update docs * support multiple providers * change promise to callbacks configure submodule on submodules.json * bug fixes * use Prebid ajax * tests fix * browsi real time data provider improvements * real time data module, browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe * change timeout&primary ad server only to auctionDelay update docs * support multiple providers * change promise to callbacks configure submodule on submodules.json * bug fixes * use Prebid ajax * tests fix * browsi real time data provider improvements * browsi-rtd-targeting-fix * nextMillennium Bid Adapter : add pbjs version and support for user.eids (prebid#10812) * added support for gpp consent string * changed test for nextMillenniumBidAdapter * added some tests * added site.pagecat, site.content.cat and site.content.language to request * lint fix * formated code * formated code * formated code * pachage-lock with prebid * pachage-lock with prebid * formatted code * added device.sua, user.eids * formatted * fixed tests * fixed bug functio getSua * Update deepintentBidAdapter.js (prebid#10818) * GC-158 When accessing the TCF it is pulling from the wrong location, use userConsent.gdpr.consentString (prebid#10808) * Adagio Analytics Adapter: listen to AUCTION_END (prebid#10798) * Adagio Analytics Adapter: add tracker on auction_end * Adagio Analytics Adapter: refacto metadata transfer * Adagio Analytics Adapter: update pba props --------- Co-authored-by: François Rotta <franz.rotta@gmail.com> * PubMaticAnalyticAdapter : Added new fields related to floors (fetch status, source of floor, provider and unique id) in analytics call (prebid#10768) * Added floors field to logger call * Added sid in logger records * Pubmatic Analytics Adapter : skip duplicate data for pubmatic bids in logger and tracker (prebid#10787) * Adding config for openwrap metadapter * Changed from http to https and timeout to 500 * Timeout value update * 1.Added safechecks for s2s metadapter case 2.Skipped firing client side tracker for pubmatic 3.Skipped adding pubmatic bid in logger * Analytics adapter changes to avoid duplicate data in case of OW S2S setup * Moved to bottom * kick off tests --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * support ad unit name (prebid#10825) * PBjs Core : new event fired before add bid response (prebid#10685) * new event before add bid response * test new event is emit * change new event name * Revert "Pubmatic Analytics Adapter : skip duplicate data for pubmatic bids in logger and tracker (prebid#10787)" (prebid#10830) This reverts commit 048f735. * Revert "support ad unit name (prebid#10825)" (prebid#10831) This reverts commit 947a487. * Invibes Bid Adapter : infinite scroll tcf (prebid#10764) * added prevent page view event param in order to differentiate from the first and following request on multi request; added disableUserSyncs in order to disable that functionality as default and added the option to activate it from the bidRequest * added infinite scroll and page refresh params, updated tcf, changed randomId to guid, updated the subdomain * reverted subdomain * Update invibesBidAdapter.js with code review suggestion * Moved new variables to invibes object * Update invibesBidAdapter.js add placementIds to invibes object * initialized window.invibes * Mediago Bid Adapter : switch domain name (prebid#10833) * Mediago Bid Adapter:new adapter * remove console * change spec file to fix CircleCI * change spec file to fix CircleCI * change spec file * Update mediagoBidAdapter.js * Update mediagoBidAdapter.js * rerun CurcleCi * update mediagoBidAdapter * update discoveryBidAdapter * Discovery Bid Adapter : parameter updates * Mediago Bid Adapter : parameter updates * Mediago Bid Adapter : code style format * rerun circleci * rerun circleci * rerun circleci * rerun circleci * Update mediagoBidAdapter & discoveryBidAdapter:report eids to server * Update mediagoBidAdapter & discoveryBidAdapter:report eids to server * update Mediago & Discovery BidAdapter:remove size filter * update Mediago & Discovery BidAdapter:code format * update Mediago & Discovery BidAdapter:code format * update Mediago & Discovery BidAdapter:add param in banner format * update mediago & discovery:first party data * update mediago & discovery:first party data * update mediago & discovery:first party data * fix(mediago & discovery): update param tagid * fix(mediago & discovery): update param tagid * feat：add imp params for analysis * fix：add imp params for analysis * code format * test:add test data & test * format code * rerun circleci * feat: 1. add cookieSync 2. add gdpr * code format * rerun circleci * add gvlid * feat:add param 1.ppuid 2.content 3.cat 4.reqtime * fix: getUserSyncs param fixed * fix: getUserSyncs param fixed * feat: add param 1. adUnitCode 2. referrer * feat: Switch domain * rerun circle ci --------- Co-authored-by: BaronYu <baronwei11@gmail.com> * Bizzclick Bid Adapter : update adapter, used ortbConverter lib (prebid#10828) * update bizzclick adapter, used ortbConverter lib * fix: removed gdpr, ccpa, coppa * PubMatic Bid Adapter : passing a unique wiid to pubmatic ssp and logger call (prebid#10821) * Added wiid as UUID * Handled undefined wiid in logger and tracker * updated test cases * updated test cases --------- Co-authored-by: pm-azhar-mulla <azhar@L1119.local> * Criteo Bid Adapter: Add support for app.publisher.id in bid request (prebid#10837) Co-authored-by: v.raybaud <v.raybaud@criteo.com> * providing visibility in case of adapter timeout and bidError (prebid#10807) Co-authored-by: ahmadlob <109217988+ahmadlob@users.noreply.github.com> * Prebid 8.28.0 release * Increment version to 8.29.0-pre * Adding support for video.plcmt (prebid#10841) * Bump github/codeql-action from 2 to 3 (prebid#10856) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HadronId Module: implementing user consent in backend calls (prebid#10845) * Implementing user consent in HadronId module * fixing tests accepting just the start of url * Eids Docs : add missing EID examples (prebid#10844) * Add missing brackets * Add missing examples * Add back missing ext * Admixer Bid Adaper: add admixerwl alias (prebid#10859) * Update README.md update * Add admixerwl alias for admixerBidAdapter. --------- Co-authored-by: Yaroslav Masenko <intgr-user@admixer.ua> * AdagioAnalyticsAdapter: fix function param check (prebid#10860) * NoBid Analytics Adapter: support for counting blocked requests for the Optimizer (prebid#10842) * Enable supplyChain support * Added support for COPPA * rebuilt * Added support for Extended User IDs. * Added support for the "meta" attribute in bid response. * Delete nobidBidAdapter.js.orig * Delete a * Delete .jsdtscope * Delete org.eclipse.wst.jsdt.ui.superType.container * Delete org.eclipse.wst.jsdt.ui.superType.name * Delete .project * Added support for counting blocked requests for the Optimizer. * Added missing function for testing. * Added unit tests --------- Co-authored-by: Reda Guermas <reda.guermas@nobid.io> * consentManagementGpp: fix handling of CMP errors (prebid#10811) * Taboola Bid Adapter: implement Iframe user sync (prebid#10789) * iframe-sync * iframe-sync-add-tests * AMX bid adapter: fix timeout handler, bump version (prebid#10744) * amx bid adapter: fix timeout handler, bump version * restore package-lock to master * remove sendbeacon, use mock xhr * add keepalive option for ajax * fix firefox test * CR changes * CR changes: restore files * CR changes * Ucfunnel Bid Adapter: add format support (prebid#10862) * Add a new ucfunnel Adapter and test page * Add a new ucfunnel Adapter and test page * 1. Use prebid lib in the repo to keep updated 2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block * utils.getTopWindowLocation is a function * Change to modules from adapters * Migrate to module design * [Dev Fix] Remove width and height which can be got from ad unit id * Update ucfunnelBidAdapter to fit into new spec * Correct the endpoint. Fix the error of query string * Add test case for ucfunnelBidAdapter * Fix lint error * Update version number * Combine all checks on bid request * Add GDPR support for ucfunnel adapter * Add in-stream video and native support for ucfunnel adapter * Remove demo page. Add more test cases. * Change request method from POST to GET * Remove unnecessary comment * Support vastXml and vastUrl for video request * update TTL to 30 mins * Avoid using arrow function which is not discuraged in mocha * ucfunnel tdid support * ucfunnel fix error message in debug mode * ucfunnel adapter add bidfloor parameter * ucfunnel adapter support CCPA * ucfunnel adapter native support clicktrackers * ucfunnel adapter change cookie sync setting * ucfunnel adapter update request parameter * Update ucfunnelBidAdapter * ucfunnel adapter add currency in ad response * ucfunnel adapter support uid2 * ucfunnel Bid Adapter: add support for FLoC and Verizon Media ConnectID * ucfunnel Bid Adapter: add support Price Floors Module * ucfunnel Bid Adapter: add GPID support and fix page and domain parameter. * ucfunnel Bid Adapter: add format support. --------- Co-authored-by: root <root@ubuntu.members.linode.com> Co-authored-by: Ryan Chou <ryanchou0210@gmail.com> Co-authored-by: ucfunnel <support@ucfunnel.com> Co-authored-by: jack.hsieh <moonnight8520@gmail.com> * R2B2 Bid Adapter: Initial release (prebid#10702) * R2B2 bidder adapter * R2B2 bid adapter: fix * conditional renderer --------- Co-authored-by: jenda <jan.schotterl@r2b2.cz> * Core: fix headers in ortbConverter readme (prebid#10874) * SparteoBidAdapter: Add UserSync (prebid#10822) * Yandex Bid Adapter: Add rtt (roud trip time) tracking via nurl (prebid#10846) * Add rtt (roud trip time) tracking via nurl in yandexBidAdapter * Yandex Bid Adapter: Fix let -> const --------- Co-authored-by: Konstantin Korobkov <kostya-kor@yandex-team.ru> * AdMatic Bid Adapter : consent management features added (prebid#10813) * Admatic Bidder Adaptor * Update admaticBidAdapter.md * Update admaticBidAdapter.md * remove floor parameter * Update admaticBidAdapter.js * Admatic Bid Adapter: alias and bid floor features activated * Admatic adapter: host param control changed * Alias name changed. * Revert "Admatic adapter: host param control changed" This reverts commit de7ac85. * added alias feature and host param * Revert "added alias feature and host param" This reverts commit 6ec8f45. * Revert "Alias name changed." This reverts commit 661c54f. * Revert "Admatic Bid Adapter: alias and bid floor features activated" This reverts commit 7a2e0e2. * Revert "Update admaticBidAdapter.js" This reverts commit 7a845b7. * Revert "remove floor parameter" This reverts commit 7a23b05. * Admatic adapter: host param control && Add new Bidder * Revert "Admatic adapter: host param control && Add new Bidder" This reverts commit 3c797b1. * commit new features * Update admaticBidAdapter.js * updated for coverage * sync updated * Update adloader.js * AdMatic Bidder: development of user sync url * Update admaticBidAdapter.js * Set currency for AdserverCurrency: bug fix * Update admaticBidAdapter.js * update * admatic adapter video params update * Update admaticBidAdapter.js * update * Update admaticBidAdapter.js * update * update * Update admaticBidAdapter_spec.js * Update admaticBidAdapter.js * Update admaticBidAdapter.js * Revert "Update admaticBidAdapter.js" This reverts commit 1216892. * Revert "Update admaticBidAdapter.js" This reverts commit b1929ec. * Revert "Update admaticBidAdapter_spec.js" This reverts commit 1ca6597. * Revert "update" This reverts commit 689ce9d. * Revert "update" This reverts commit f381a45. * Revert "Update admaticBidAdapter.js" This reverts commit 38fd7ab. * Revert "update" This reverts commit a5316e7. * Revert "Update admaticBidAdapter.js" This reverts commit 60a28ca. * Revert "admatic adapter video params update" This reverts commit 31e69e8. * update * Update admaticBidAdapter.js * Update admaticBidAdapter_spec.js * mime_type add * add native adapter * AdMatic Adapter: Consent Management * Taboola Bid Adapter: Cookie Look Up Logic Fix (prebid#10873) * cookie-look-up-logic-fix * cookie-look-up-logic-fix * cookie-look-up-logic-fix * ZetaGlobalSsp Bid Adapter : support topics module (prebid#10803) * add getTopics() * provide get segments from ortb2 * rename const * additional check * fix test --------- Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com> Co-authored-by: Alexey Surovenko <ASurovenko@vdhk6ddf9m.home> * Adnuntius Bid Adapter: bugfix for storageFunction (prebid#10869) * Removed linting issues * Fixed merge issues. * Bugfix on storageTool. * Prebid 8.29.0 release * Increment version to 8.30.0-pre * Yandex Bid Adapter: add support for topicsFpdModule (prebid#10875) * Yandex Bid Adapter: add support for topicsFpdModule * add test * Yandex Bid Adapter: add jsdoc (prebid#10884) * DxKulture Bid Adapter : user syncs improvements (prebid#10738) * Initial implementation of kulturemedia bid adapter * Changing outstream to instream * Enriching md file with test examples * Changing nId to networkId * Cleaning up md file * Submitting rebranded dxkultureBidAdapter * dxkultureBidAdapter - Improve UserSyncs * Include gdpr/usp params in iframe usersync url * Add gdpr/usp data to iframe usync urls * Cleaning up testing html file * Adding outstream support * Updating exchange endpoint * Resolve requests test * Resolving iframe/pixel priority when iframeEnabled/pixelEnabled * Improving userSync filtering condition * Prioritize iframe user syncing --------- Co-authored-by: Danijel Predarski <danijel.p@whitecitysoft.com> Co-authored-by: dani-nova <73398187+dani-nova@users.noreply.github.com> Co-authored-by: Slavisa Petkovic <trpeze@gmail.com> Co-authored-by: Slavisa Petkovic <32300768+spetkovic@users.noreply.github.com> * Mygaru Id System: Initial release (prebid#10848) * Update viantOrtbBidAdapter_spec.js (prebid#10888) Added a test case for native ads * Stv Bid Adapter: added user id support, adaptation of schain support (prebid#10849) * initial commit * adapted buildRequests function * refinement pfilter and bcat * refinement * adapted tests for isBidRequestValid,buildRequests * adaptations for test * finished building stvBidAdapter.js * finished: ran tests, coverage 99% * update: rename w->srw, h->srh * adapt stvBidAdapter.md * remove dspx from stv adapters * some changes (missing: getUserSyncs, but is the same as in radsBidAdapter) * added checks in getUserSyncs; ran tests * added schain support (94.8% coverage) * correct schain encoding * added serializeUids and adapted serializeSChain --------- Co-authored-by: theo_ <theo_@IDEA3> * Missena Bid Adapter: allow per page capping (prebid#10863) * LiveIntent ID Module: Update live-connect version (prebid#10894) * update lc version * fix typo * Do not require API for video requests (prebid#10895) * Price Floors: Failure to Account for 'data.skipRate' (prebid#10872) * Update skipRate handling in priceFloors.js and add unit tests for the changes. * Update wording on tests and remove unecessary spread. * Prebid 8.30.0 release * add prebid analyticsS --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: PGAMSSP <142323401+PGAMSSP@users.noreply.github.com> Co-authored-by: John Ivan Bauzon <johnbauzon@gmail.com> Co-authored-by: John Bauzon <john.bauzon@gumgum.com> Co-authored-by: Omer Dotan <54346241+omerBrowsi@users.noreply.github.com> Co-authored-by: Malkov Mikhail <mhlmlkv@gmail.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Chris Southern <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: Olivier <osazos@adagio.io> Co-authored-by: François Rotta <franz.rotta@gmail.com> Co-authored-by: kapil-tuptewar <91458408+kapil-tuptewar@users.noreply.github.com> Co-authored-by: pm-priyanka-deshmane <107103300+pm-priyanka-deshmane@users.noreply.github.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Marco Muths <gwi-mmuths@users.noreply.github.com> Co-authored-by: matthieularere-msq <63732822+matthieularere-msq@users.noreply.github.com> Co-authored-by: gabrielIvbs <112690249+gabrielIvbs@users.noreply.github.com> Co-authored-by: BaronJHYu <254878848@qq.com> Co-authored-by: BaronYu <baronwei11@gmail.com> Co-authored-by: BizzClick <73241175+BizzClick@users.noreply.github.com> Co-authored-by: pm-azhar-mulla <75726247+pm-azhar-mulla@users.noreply.github.com> Co-authored-by: pm-azhar-mulla <azhar@L1119.local> Co-authored-by: Vincent <vincent.r06@gmail.com> Co-authored-by: v.raybaud <v.raybaud@criteo.com> Co-authored-by: barRubi <151519394+barRubi@users.noreply.github.com> Co-authored-by: ahmadlob <109217988+ahmadlob@users.noreply.github.com> Co-authored-by: Nayan Savla <nsavla@yieldmo.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: joseluis laso <jlaso@users.noreply.github.com> Co-authored-by: Viktor Dreiling <34981284+3link@users.noreply.github.com> Co-authored-by: AdmixerTech <35560933+AdmixerTech@users.noreply.github.com> Co-authored-by: Yaroslav Masenko <intgr-user@admixer.ua> Co-authored-by: redaguermas <redaguermas@gmail.com> Co-authored-by: Reda Guermas <reda.guermas@nobid.io> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Nick Jacob <nickbjacob@gmail.com> Co-authored-by: jackhsiehucf <77815341+jackhsiehucf@users.noreply.github.com> Co-authored-by: root <root@ubuntu.members.linode.com> Co-authored-by: Ryan Chou <ryanchou0210@gmail.com> Co-authored-by: ucfunnel <support@ucfunnel.com> Co-authored-by: jack.hsieh <moonnight8520@gmail.com> Co-authored-by: alexalukr2b2 <136449554+alexalukr2b2@users.noreply.github.com> Co-authored-by: jenda <jan.schotterl@r2b2.cz> Co-authored-by: Denis <7009699+someden@users.noreply.github.com> Co-authored-by: geoffray-viously <95097046+geoffray-viously@users.noreply.github.com> Co-authored-by: Konstantin Korobkov <korobkov-k@users.noreply.github.com> Co-authored-by: Konstantin Korobkov <kostya-kor@yandex-team.ru> Co-authored-by: Fatih Kaya <fatih.kaya.84@gmail.com> Co-authored-by: asurovenko-zeta <80847074+asurovenko-zeta@users.noreply.github.com> Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com> Co-authored-by: Alexey Surovenko <ASurovenko@vdhk6ddf9m.home> Co-authored-by: Mikael Lundin <mikael-lundin@users.noreply.github.com> Co-authored-by: kmdevops <126434358+kmdevops@users.noreply.github.com> Co-authored-by: Danijel Predarski <danijel.p@whitecitysoft.com> Co-authored-by: dani-nova <73398187+dani-nova@users.noreply.github.com> Co-authored-by: Slavisa Petkovic <trpeze@gmail.com> Co-authored-by: Slavisa Petkovic <32300768+spetkovic@users.noreply.github.com> Co-authored-by: Gena <wertixvost@gmail.com> Co-authored-by: tkrishnaviant <tkrishna@viantinc.com> Co-authored-by: theo-stv <120092078+theo-stv@users.noreply.github.com> Co-authored-by: theo_ <theo_@IDEA3> Co-authored-by: Petre Damoc <pdamoc@gmail.com> Co-authored-by: Wiem Zine El Abidine <welabidine@liveintent.com> Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com> Co-authored-by: bbaresic <153560835+bbaresic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
This workarround will support usage of ad slot name next to div element ID according to official documentation. See https://docs.prebid.org/dev-docs/adunit-reference.html#adunit code parameter description:
An identifier you create and assign to this ad unit. Generally this is set to the ad slot name or the div element ID.
We will also contact the maintainer of this adapter about this issue, mentioned in https://github.com/prebid/Prebid.js/blob/master/modules/teadsBidAdapter.md. This pull request can be a reference for a fully fledged change request
Other information
#10824