Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenWeb adapter refactoring #11115

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

alexander-plotnikov-openweb
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org/?

  • Other

Description of change

Adapter refactoring to support latest prebid requirements

Other information

@alexander-plotnikov-openweb
Copy link
Contributor Author

Hello @osazos, is there anything that's holding back the PR process from our side?

Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexander-plotnikov-openweb I just added some comments. Btw all the rest sounds good.

modules/openwebBidAdapter.js Outdated Show resolved Hide resolved
modules/openwebBidAdapter.js Outdated Show resolved Hide resolved
modules/openwebBidAdapter.js Outdated Show resolved Hide resolved
modules/openwebBidAdapter.js Show resolved Hide resolved
modules/openwebBidAdapter.js Outdated Show resolved Hide resolved
@osazos osazos self-requested a review March 28, 2024 08:39
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osazos osazos merged commit f072634 into prebid:master Mar 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants