Dailymotion Bid Adapter: accept ortb2 field #11366

sebmil-daily · 2024-04-19T14:59:41Z

Type of change

Other : docs PR updated (prebid.github.io) -> Dailymotion Bid Adaptor: initial release prebid.github.io#5091

Description of change

This addresses the comments that we received after #10970 was merged.

The main changes are:

use standard ORTB video parameters as fallback
support several new ORTB video fields
better request validation to exclude non video/instream requests
preliminary support for in-app requests

Dailymotion Bid Adaptor: initial release

…lbacks

The same way as we can have an array of IAB categories level 1 in the ORTB request, this PR introduces an array for the IAB categories level 2. To be forward compatible with level [2.2](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%202.2.tsv) and [3.0](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%203.0.tsv) specifications, the category IDs should be sent as strings.

feat(LEO-528): Allow multiple IAB categories level 2 in video metadata

…h player context

Dailymotion bid adapter: Clarify the video metadata to provide in each player context

Co-authored-by: Rumesh <rumesh@users.noreply.github.com>

…to_bidparam Dailymotion bid adapter: Move API key to bid params (fix tests)

Dailymotion Bid Adaptor: add iabcat1 and fallback to ortb2 for iabcat2

…ocument mapping of ortb2 fpd to video metadata

Note: I changed the case of `startdelay` to be consistent with the other parameters, but it won't have any impact on current deployments as this parameter is not used onsite.

…deo_fields Dailymotion Bid Adaptor: Add standard ORTB video parameters

# Conflicts: # modules/dailymotionBidAdapter.js # modules/dailymotionBidAdapter.md # test/spec/modules/dailymotionBidAdapter_spec.js

Merge upstream

sebmil-daily · 2024-04-19T15:09:43Z

Sorry for the long list of commits coming from the upstream merge in our fork. We'll rebase it as soon as this one is merged.

cc. @patmmccann and @karimMourra, thanks again for your time and comments, we are open to any new suggestion :)

karimMourra · 2024-04-19T18:59:35Z

modules/dailymotionBidAdapter.js

@@ -38,17 +45,22 @@ function getVideoMetadata(bidRequest, bidderRequest) {
  const videoMetadata = {
    description: videoParams.description || '',
    duration: videoParams.duration || 0,


Suggested change

duration: videoParams.duration || 0,

duration: videoParams.duration || contentObj.len || 0,

Per spec: len - integer - Length of content in seconds; appropriate for video or audio

modules/dailymotionBidAdapter.js

modules/dailymotionBidAdapter.md

…aTypes.video

sebmil-daily · 2024-04-24T08:21:48Z

Thanks @karimMourra for all the suggestions. I think @kvnsw adressed all of them, could you confirm please ?

patmmccann · 2024-05-07T14:38:28Z

LGTM

@karimMourra if you have additional feedback let's handle in subsequent pr's

karimMourra · 2024-05-07T18:52:09Z

Apologies, I lost track of this PR. The changes look great thank you for addressing!
Swing by the Video Taskforce sync sometime! We meet every 2 weeks on Thursdays at 12PM EST. We are meeting this week.

* Dailymotion Bid Adaptor: initial release * .md file lint issue resolved * Dailymotion Bid Adaptor: build bidder request based on param with fallbacks * Dailymotion Bid Adaptor: support video metadata * Dailymotion Bid Adaptor: add support for sending adUnitCode * Dailymotion Bid Adaptor: add support for sending startDelay * feat(LEO-528): Allow multiple IAB categories in video metadata The same way as we can have an array of IAB categories level 1 in the ORTB request, this PR introduces an array for the IAB categories level 2. To be forward compatible with level [2.2](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%202.2.tsv) and [3.0](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%203.0.tsv) specifications, the category IDs should be sent as strings. * Dailymotion bid adapter: Clarify the video metadata to provide in each player context * Dailymotion bid adapter: Move API key to bid params * Dailymotion bid adapter: Verify API key is string Co-authored-by: Rumesh <rumesh@users.noreply.github.com> * Dailymotion bid adapter: Move API key to bid params (fix tests) * Dailymotion Bid Adaptor: add gpp support and get coppa from request * Dailymotion Bid Adaptor: fix lint error * Dailymotion Bid Adaptor: add iabcat1 and fallback to ortb2 for iabcat2 * Dailymotion Bid Adaptor: get iabcats from ortb2.site.content.data * Dailymotion Bid Adaptor: get content data from ortb2.site.content * Dailymotion Bid Adaptor: add support for iabcat1 in videoParams and document mapping of ortb2 fpd to video metadata * Dailymotion Bid Adaptor: add support for Object: App * Dailymotion Bid Adaptor: only support video adunits in context instream * Dailymotion bid adapter: Add standard ORTB video parameters Note: I changed the case of `startdelay` to be consistent with the other parameters, but it won't have any impact on current deployments as this parameter is not used onsite. * Dailymotion Bid Adaptor: add support for livestream and app * Dailymotion Bid Adaptor: drop support for non standard fields in mediaTypes.video * Dailymotion Bid Adaptor: update docs examples --------- Co-authored-by: Kevin Siow <kevin.siow@dailymotion.com> Co-authored-by: Aditi Chaudhary <aditichaudhary175@gmail.com> Co-authored-by: Kevin Siow <k.siow@passerelle.co> Co-authored-by: Rumesh <rumesh@users.noreply.github.com>

Kevin Siow and others added 30 commits January 22, 2024 17:22

Dailymotion Bid Adaptor: initial release

5b534be

.md file lint issue resolved

807c75b

Merge pull request #3 from dailymotion-oss/feat/dailymotion-adaptor

9eb2277

Dailymotion Bid Adaptor: initial release

Merge branch 'prebid:master' into master

3b3878e

Dailymotion Bid Adaptor: build bidder request based on param with fal…

6c25624

…lbacks

Dailymotion Bid Adaptor: support video metadata

9aab2ea

Merge branch 'prebid:master' into master

7ee40c4

Dailymotion Bid Adaptor: add support for sending adUnitCode

32d6391

Merge branch 'prebid:master' into master

d5542db

Dailymotion Bid Adaptor: add support for sending startDelay

ce0536c

Merge branch 'prebid:master' into master

9a97052

Merge pull request #10 from dailymotion-oss/LEO-528_multiple_iabcat2

4b78d35

feat(LEO-528): Allow multiple IAB categories level 2 in video metadata

Dailymotion bid adapter: Clarify the video metadata to provide in eac…

09f8e16

…h player context

Merge pull request #11 from dailymotion-oss/LEO-528_fix_metadata_doc

44b88d1

Dailymotion bid adapter: Clarify the video metadata to provide in each player context

Dailymotion bid adapter: Move API key to bid params

898d8bb

Dailymotion bid adapter: Verify API key is string

673f831

Co-authored-by: Rumesh <rumesh@users.noreply.github.com>

Merge branch 'prebid:master' into master

53bd3df

Dailymotion bid adapter: Move API key to bid params (fix tests)

fbd456d

Merge pull request #13 from dailymotion-oss/dailymotion_move_api_key_…

2bfbc13

…to_bidparam Dailymotion bid adapter: Move API key to bid params (fix tests)

Merge branch 'prebid:master' into master

b908269

Dailymotion Bid Adaptor: add gpp support and get coppa from request

cc0c1bc

Merge branch 'prebid:master' into master

cc5f6ff

Dailymotion Bid Adaptor: fix lint error

fa56a41

Dailymotion Bid Adaptor: add iabcat1 and fallback to ortb2 for iabcat2

36637e0

Merge pull request #16 from dailymotion-oss/dailymotion_iabcat

cff7c34

Dailymotion Bid Adaptor: add iabcat1 and fallback to ortb2 for iabcat2

Dailymotion Bid Adaptor: get iabcats from ortb2.site.content.data

50dda1f

Dailymotion Bid Adaptor: get content data from ortb2.site.content

2a38bac

Dailymotion Bid Adaptor: add support for iabcat1 in videoParams and d…

bcaaa60

…ocument mapping of ortb2 fpd to video metadata

Dailymotion Bid Adaptor: add support for Object: App

091eec5

Kevin Siow and others added 6 commits April 19, 2024 15:45

Dailymotion Bid Adaptor: only support video adunits in context instream

7a5b070

Dailymotion bid adapter: Add standard ORTB video parameters

729647b

Note: I changed the case of `startdelay` to be consistent with the other parameters, but it won't have any impact on current deployments as this parameter is not used onsite.

Merge pull request #19 from dailymotion-oss/GLUE-16296_handle_ortb_vi…

c80dd13

…deo_fields Dailymotion Bid Adaptor: Add standard ORTB video parameters

Dailymotion Bid Adaptor: add support for livestream and app

6e36b69

Merge remote-tracking branch 'upstream/master' into merge_upstream

38a0079

# Conflicts: # modules/dailymotionBidAdapter.js # modules/dailymotionBidAdapter.md # test/spec/modules/dailymotionBidAdapter_spec.js

Merge pull request #21 from dailymotion-oss/merge_upstream

a53f4c0

Merge upstream

ChrisHuie requested review from patmmccann and karimMourra April 19, 2024 16:06

ChrisHuie assigned karimMourra and patmmccann Apr 19, 2024

ChrisHuie added the maintenance label Apr 19, 2024

patmmccann changed the title ~~Dailymotion Bid Adapter leftovers~~ Dailymotion Bid Adapter: accept ortb2 field Apr 19, 2024

karimMourra requested changes Apr 19, 2024

View reviewed changes

patmmccann removed their request for review April 19, 2024 20:34

patmmccann removed their assignment Apr 19, 2024

kvnsw and others added 3 commits April 20, 2024 10:12

Merge branch 'prebid:master' into master

5c209c0

Dailymotion Bid Adaptor: drop support for non standard fields in medi…

ae8de5f

…aTypes.video

Dailymotion Bid Adaptor: update docs examples

80b6dfe

sebmil-daily requested a review from karimMourra April 24, 2024 08:20

patmmccann approved these changes May 7, 2024

View reviewed changes

patmmccann merged commit 14d2a0e into prebid:master May 7, 2024
4 checks passed

This was referenced May 7, 2024

Dailymotion Bid Adapter: Exclude non standard fields from mediaTypes.video prebid/prebid.github.io#5305

Closed

Dailymotion Bid Adapter: Exclude non standard fields from mediaTypes.video dailymotion-oss/prebid.github.io#9

Merged

sebmil-daily mentioned this pull request May 13, 2024

Dailymotion Prebid Adapter: documentation update prebid/prebid.github.io#5310

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dailymotion Bid Adapter: accept ortb2 field #11366

Dailymotion Bid Adapter: accept ortb2 field #11366

sebmil-daily commented Apr 19, 2024 •

edited

sebmil-daily commented Apr 19, 2024 •

edited

karimMourra Apr 19, 2024

sebmil-daily commented Apr 24, 2024

patmmccann commented May 7, 2024

karimMourra commented May 7, 2024

	duration: videoParams.duration \|\| 0,
	duration: videoParams.duration \|\| contentObj.len \|\| 0,

Dailymotion Bid Adapter: accept ortb2 field #11366

Dailymotion Bid Adapter: accept ortb2 field #11366

Conversation

sebmil-daily commented Apr 19, 2024 • edited

Type of change

Description of change

sebmil-daily commented Apr 19, 2024 • edited

karimMourra Apr 19, 2024

Choose a reason for hiding this comment

sebmil-daily commented Apr 24, 2024

patmmccann commented May 7, 2024

karimMourra commented May 7, 2024

sebmil-daily commented Apr 19, 2024 •

edited

sebmil-daily commented Apr 19, 2024 •

edited