Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UtiqMtpIdSystem: create the Utiq MTP ID submodule #11372

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

jdelhommeau
Copy link
Collaborator

Type of change

  • Feature: Adding a new ID Submodule: UtiqMTPIdSystem

Description of change

Creating a new ID Submodule, UtiqMTP. This ID is complementary to the other Utiq ID Module. It returns a different version of the Utiq ID (first party ID) which can be leveraged by publishers for additional use cases. This ID modules comes with its own bidder restriction, etc.

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Apr 22, 2024

@jdelhommeau do not see any docs around this id in our docs repo or any unit tests. Can you please add ?https://github.com/prebid/prebid.github.io

@jdelhommeau
Copy link
Collaborator Author

thank you @ChrisHuie and sorry about missing doc and unit test. I added both (PR for the doc is prebid/prebid.github.io#5270).
Let me know if all good or anything else missing.

Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one comment from me on documentation, otherwise the module code itself looks fine.

modules/utiqMtpIdSystem.md Show resolved Hide resolved
…der to integrate the Utiq script on their site
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smenzer smenzer merged commit b557f04 into prebid:master Apr 25, 2024
4 checks passed
@jdelhommeau jdelhommeau deleted the utiq-mtp branch April 26, 2024 09:03
Ticki84 pushed a commit to criteo-forks/Prebid.js that referenced this pull request May 14, 2024
* Creating new user ID module utiqMtpIdSystem to provide option for publishers using Utiq to send the martechPass. This is complementary to the UtiqIDSystem module

* fixing documentation to reflect correct name utiqMtp instead of utiq-mtp

* fixing inline doc and creating unit test for utiqMtpIdSystem

* Adding extra documentation to notify publishers to contact Utiq in order to integrate the Utiq script on their site

---------

Co-authored-by: root <root@jdelhommeau-devbox.vps.local>
Co-authored-by: jdelhommeau <julien.delhommeau@utiq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants