Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery Bid Adapter : get UTM tag data #11380

Merged
merged 18 commits into from
May 6, 2024
Merged

Conversation

ecoeco163
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

get UTM tag data

Other information

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs tests

@ecoeco163
Copy link
Contributor Author

Hi, I have add unit test

@ChrisHuie ChrisHuie removed the request for review from mmoschovas May 6, 2024 20:58
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned mmoschovas May 6, 2024
@ChrisHuie ChrisHuie merged commit 55d008a into prebid:master May 6, 2024
4 checks passed
Ticki84 pushed a commit to criteo-forks/Prebid.js that referenced this pull request May 14, 2024
* feat(isBidRequestValid): just filter token once. not filter publisher and tagid

* feat(isBidRequestValid): add unit test

* feat(spec): fix eslint

* feat(spec): fix unit test

* feat(spec): fix unit test

* feat(ext): change default value

* feat(utm): build UTMTag data

* feat(spec): fix utm test

* feat(utm): get UTMTag

* feat(utm): add unit tests

* feat(utm): fix unit tests

* feat(utm): fix unit tests

* feat(utm): fix unit tests

---------

Co-authored-by: yubei01 <yubei01@baidu.com>
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request May 21, 2024
* feat(isBidRequestValid): just filter token once. not filter publisher and tagid

* feat(isBidRequestValid): add unit test

* feat(spec): fix eslint

* feat(spec): fix unit test

* feat(spec): fix unit test

* feat(ext): change default value

* feat(utm): build UTMTag data

* feat(spec): fix utm test

* feat(utm): get UTMTag

* feat(utm): add unit tests

* feat(utm): fix unit tests

* feat(utm): fix unit tests

* feat(utm): fix unit tests

---------

Co-authored-by: yubei01 <yubei01@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants