Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appnexus Bid Adapter : video plcmt logic fix #11403

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

jsnellbaker
Copy link
Collaborator

@jsnellbaker jsnellbaker commented Apr 26, 2024

Type of change

  • Bugfix

Description of change

Fixes #11400

This PR fixes part of the logic when checking that ortbStartDelay was intentionally set to 0

CC: @weylandjung

@jsnellbaker jsnellbaker requested a review from Fawke April 26, 2024 14:39
@ChrisHuie ChrisHuie changed the title appnexusBidAdapter - video plcmt logic fix Appnexus Bid Adapter : video plcmt logic fix Apr 26, 2024
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned Fawke Apr 27, 2024
@ChrisHuie ChrisHuie removed the request for review from Fawke April 27, 2024 20:24
@ChrisHuie ChrisHuie merged commit 1243f21 into master Apr 28, 2024
4 checks passed
@ChrisHuie ChrisHuie deleted the appnexus_plcmt_fix branch April 28, 2024 01:03
ChrisHuie pushed a commit that referenced this pull request May 6, 2024
* sovrn analytics adapter: remove analytics adapter

* delete md

* Appnexus Bid Adapter: add support for ast_override_div debug feature (#11390)

* ConsentManagementGpp module: throw error on some invalid sections (#11385)

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update modules/consentManagementGpp.js

Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

---------

Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

* appnexusBidAdapter - video plcmt logic fix (#11403)

* Remove 'transformBidParams' from relevantdigitalBidAdapter (#11412)

* resolve conflicts/merge

---------

Co-authored-by: Chris Prokopiak <cprokopiak@sovrn.com>
Co-authored-by: Dmitry Sinev <astartsky@pm.me>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com>
Ticki84 pushed a commit to criteo-forks/Prebid.js that referenced this pull request May 14, 2024
* sovrn analytics adapter: remove analytics adapter

* delete md

* Appnexus Bid Adapter: add support for ast_override_div debug feature (prebid#11390)

* ConsentManagementGpp module: throw error on some invalid sections (prebid#11385)

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update modules/consentManagementGpp.js

Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

---------

Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

* appnexusBidAdapter - video plcmt logic fix (prebid#11403)

* Remove 'transformBidParams' from relevantdigitalBidAdapter (prebid#11412)

* resolve conflicts/merge

---------

Co-authored-by: Chris Prokopiak <cprokopiak@sovrn.com>
Co-authored-by: Dmitry Sinev <astartsky@pm.me>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com>
Ticki84 pushed a commit to criteo-forks/Prebid.js that referenced this pull request May 14, 2024
zkosanovic pushed a commit to OpenWeb-Public/Prebid.js that referenced this pull request May 29, 2024
* sovrn analytics adapter: remove analytics adapter

* delete md

* Appnexus Bid Adapter: add support for ast_override_div debug feature (prebid#11390)

* ConsentManagementGpp module: throw error on some invalid sections (prebid#11385)

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update modules/consentManagementGpp.js

Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

---------

Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

* appnexusBidAdapter - video plcmt logic fix (prebid#11403)

* Remove 'transformBidParams' from relevantdigitalBidAdapter (prebid#11412)

* resolve conflicts/merge

---------

Co-authored-by: Chris Prokopiak <cprokopiak@sovrn.com>
Co-authored-by: Dmitry Sinev <astartsky@pm.me>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppNexus Bid Adapter : plcmt and startdelay mapping function not returning correct values
4 participants