-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appnexus Bid Adapter : video plcmt logic fix #11403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
appnexusBidAdapter - video plcmt logic fix
Appnexus Bid Adapter : video plcmt logic fix
Apr 26, 2024
weylandjung
approved these changes
Apr 26, 2024
ChrisHuie
approved these changes
Apr 27, 2024
ChrisHuie
pushed a commit
that referenced
this pull request
May 6, 2024
* sovrn analytics adapter: remove analytics adapter * delete md * Appnexus Bid Adapter: add support for ast_override_div debug feature (#11390) * ConsentManagementGpp module: throw error on some invalid sections (#11385) * Update consentManagementGpp.js * Update consentManagementGpp.js * Update consentManagementGpp.js * Update consentManagementGpp.js * Update modules/consentManagementGpp.js Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * appnexusBidAdapter - video plcmt logic fix (#11403) * Remove 'transformBidParams' from relevantdigitalBidAdapter (#11412) * resolve conflicts/merge --------- Co-authored-by: Chris Prokopiak <cprokopiak@sovrn.com> Co-authored-by: Dmitry Sinev <astartsky@pm.me> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com>
Ticki84
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
May 14, 2024
* sovrn analytics adapter: remove analytics adapter * delete md * Appnexus Bid Adapter: add support for ast_override_div debug feature (prebid#11390) * ConsentManagementGpp module: throw error on some invalid sections (prebid#11385) * Update consentManagementGpp.js * Update consentManagementGpp.js * Update consentManagementGpp.js * Update consentManagementGpp.js * Update modules/consentManagementGpp.js Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * appnexusBidAdapter - video plcmt logic fix (prebid#11403) * Remove 'transformBidParams' from relevantdigitalBidAdapter (prebid#11412) * resolve conflicts/merge --------- Co-authored-by: Chris Prokopiak <cprokopiak@sovrn.com> Co-authored-by: Dmitry Sinev <astartsky@pm.me> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com>
Ticki84
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
May 14, 2024
zkosanovic
pushed a commit
to OpenWeb-Public/Prebid.js
that referenced
this pull request
May 29, 2024
* sovrn analytics adapter: remove analytics adapter * delete md * Appnexus Bid Adapter: add support for ast_override_div debug feature (prebid#11390) * ConsentManagementGpp module: throw error on some invalid sections (prebid#11385) * Update consentManagementGpp.js * Update consentManagementGpp.js * Update consentManagementGpp.js * Update consentManagementGpp.js * Update modules/consentManagementGpp.js Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * appnexusBidAdapter - video plcmt logic fix (prebid#11403) * Remove 'transformBidParams' from relevantdigitalBidAdapter (prebid#11412) * resolve conflicts/merge --------- Co-authored-by: Chris Prokopiak <cprokopiak@sovrn.com> Co-authored-by: Dmitry Sinev <astartsky@pm.me> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes #11400
This PR fixes part of the logic when checking that ortbStartDelay was intentionally set to
0
CC: @weylandjung