add feature to bridgewellBidAdapter #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add feature to bridgewellBidAdapter
add feature to bridgewellBidAdapter
[FEAT] hoist bidder version
jsnellbaker
approved these changes
May 2, 2018
There was a problem hiding this comment.
Hi @wuleo Thanks for putting these changes together. The code looks good and the test param information you provided was working fine for me.
My only request would be to submit a separate PR in the docs repo and add the following variable to your bidders page in the bidders directory so that you're noted as supporting Native.
media_types: native
If you create this docs PR, we should be good to merge here.
|
Hi @jsnellbaker, very appreciate for your review. |
|
Docs PR confirmed. Merging. |
|
Thanks for your review. |
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* [FEAT] support mediaTypes.banner.sizes * [FEAT] init native * [FEAT] init bw version * [FEAT] hoist bidder version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
To support mediaType native