fixes #3128 YieldlabBidAdapter is not using bidRequest.params.adSize #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dSize as customsize in bidResponse
harpere
reviewed
Sep 27, 2018
…dSize as customsize in bidResponse - add test
harpere
approved these changes
Sep 28, 2018
ArmandChoy
pushed a commit
to RockYou-Ads/Prebid.js
that referenced
this pull request
Sep 28, 2018
* 'master' of https://github.com/prebid/Prebid.js: (367 commits) Rubicon adapter: get referrer from bidderRequest.refererInfo.referer; (prebid#3087) Minor freewheel-ssp update (prebid#3119) fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize (prebid#3129) Support Video Renderer (prebid#3104) Fix for Issue 3130: passing new copy of adUnits object to every adapter (prebid#3131) Add video params to Beachfront adapter (prebid#3121) Sonobi - Fix ref encoding (prebid#3125) update circleci link to just Prebid.js builds (prebid#3132) Bugfix: Issue 3111 (prebid#3122) increment prebid version Prebid 1.25.0 Release adding account to s2s bidder-sync request (prebid#3123) Revert "Trafficroots Bid Adapter Submission (prebid#2993)" (prebid#3124) Trafficroots Bid Adapter Submission (prebid#2993) add versioning and deprecation policy doc (prebid#3103) improving kargo unit tests for currency handling (prebid#3106) AdOcean adapter improvment (prebid#3011) Serverbid Bid Adapter: Add pubnx alias (prebid#3064) Adds an id parameter (prebid#3107) added sizes for rubicon (prebid#3094) ...
SublimeJeremy
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Oct 1, 2018
…dSize (prebid#3129) * fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse * fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse - add test
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…dSize (prebid#3129) * fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse * fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse - add test
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…dSize (prebid#3129) * fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse * fixes prebid#3128 YieldlabBidAdapter is not using bidRequest.params.adSize as customsize in bidResponse - add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
when bidRequest.params.adSize is available, it has to be used in bidResponse or it will impact ad delivery
Other information