-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi bidder prebid server #3618
Conversation
My take - this should really be fixed in Prebid Server, not PBJS. Since the issue has been outstanding for a year, I'd like to understand why the issue can't persist for another couple of weeks while the Go and Java versions of the servers are patched. Once we do patch this in PBS, this alias workaround would need to be removed. |
@bretg , agree but the issue is PBJS will also have to pass the bid.bidder property several time. |
ok, but my vote would be to not create aliases. Adding @mkendall07 for his take. In otherwords, I propose the alias part of this PR gets removed. |
Hi Bret, the logic then will have to be different. Here is the bidder is present several time I am passing it as a new property name (pubmatic, pubmaticAlias_1,...). The 3 Solutions I am seeing are:
|
Speaking for PubMatic, we should really fix our ad slot validation in our Prebid Server adapter. The client-side adapter now supports multi-sized ad units but our server-side adapter is failing to validate them. I'll get this taken care of in the PubMatic Prebid Server adapter. |
@mike-chowla Thanks for the update. Will be indeed better to wait for the PubMatic Prebid Server adapter thus. |
+1 to Bret's comment. Let's address in PBS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather be fixed in PBS
I have closed this PR as it will be fixed in PBS! Thanks, |
Some bidders such as Pubmatic and Index are using a bid for each ad size as they don’t support multi-size. It is fine on client side except the fact that it will trigger 2 requests.
However, it is NOT working for Prebid server as only the last bid will be triggered server side.
As you can in the following test page, only the last Pubmatic bid (1410742@320x50) is sent to Prebid server and the first one is not present in the request (1410741@320x100):
https://jsfiddle.net/cbqzrjhx/
You can create an alias as a workaround and I have added this logic in the prebidBidServerBidAdapter to add an alias if the adUnit has multiple time the same bidder.
Thanks
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information