pass site.{} into prebid server request #3783
Conversation
One publisher want to pass keywords to prebid server and current code only read pbjs.setConfig(app{}) not site.
Prebid server is already able to read data passed in $.site.keywords
|
Thanks for the PR @AntoineJac, but would like to bring this in line with the design for first party data we finalized in #3687
Finally, I'm not comfortable that this proposed change has the side-effect of removing site.publisher and site.page if the user doesn't provide them. So my requested change is to specify keywords in This change should ideally be packaged with the full implementation of first party data (which is on the Rubicon internal queue), but I gather you have a more immediate need for keywords, so I suppose jumping the gun on this one part of first party data is ok. On a tangent, why do we accept
Searched for the history of this feature but it's pretty old -- beyond the refactoring. Anyone recall the use case? If not, I propose removing it. That wouldn't really be a breaking change because it undocumented. |
|
@bretg , here the documentation for setConfig({app}): This is important to not remove it as I have several clients using it on a postbid environment! Regarding setConfig({site}) I am ok to wait for the new design for first party data. Thanks |
|
Good to know. Made a PR to update the post-bid docs. prebid/prebid.github.io#1288 Can we close this PR then? |
|
Yes perfect thanks @bretg |
Type of change
Description of change
Some publisher want to pass keywords to prebid server and current code only read pbjs.setConfig(app{}) not pbjs.setConfig(site{})
This code will pass the data in config.site to the prebid server request
Other information
Prebid server is already able to read data passed in $.site.keywords