change in Aardvark adapter to handle additional data #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Your test coverage is low:
I'm going to approve this since the these changes aren't reducing coverage but for your next pull request, please get your test coverage above the 80% bar. |
|
Thank you @mike-chowla , we'll fix the coverage for the next PR |
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* added property ex to rawBid * removed utils.getTopWindowUrl()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Aardvark will send, together with the bid data, an optional
exproperty that may contain some useful information. We want to pass it together with the bid.Also, we removed
utils.getTopWindowUrl()function calls and refactored the code and the tests to use `refererInfo.referer'.contact email of the adapter’s maintainer
chris@rtk.io
official adapter submission