Digitrust submodule #3867
Merged
Digitrust submodule #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtingleff
reviewed
May 30, 2019
modules/digiTrustIdSystem.md
Outdated
| DigiTrust may be initialized in the standard manner or through the params | ||
| object. | ||
|
|
||
| You can use npm or reference the script on the cdn. |
There was a problem hiding this comment.
suggest removing this stuff about referencing a script on the CDN, or using npm... let's make it as easy as possible, and no easier.
There was a problem hiding this comment.
Removed and added in more complete instructions from doc site.
idettman
reviewed
May 30, 2019
idettman
suggested changes
May 30, 2019
This reverts commit c1fc37a. # Conflicts: # modules/digiTrustIdSystem.js # modules/digiTrustIdSystem.md
goosemanjack
commented
Jun 4, 2019
jaiminpanchal27
approved these changes
Jun 5, 2019
idettman
approved these changes
Jun 5, 2019
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Initial checkin with submodule support for DigiTrust. * Addition of simple example file * DigiTrust submodule now functioning with new userId system. * Addition of Full example and confirming to work with or without DigiTrust library. * Update based upon code review requests. * Revert "Initial checkin with submodule support for DigiTrust." This reverts commit c1fc37a. # Conflicts: # modules/digiTrustIdSystem.js # modules/digiTrustIdSystem.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds DigiTrust support to the updated userId system.
Type of change
Description of change
This is an update to add DigiTrust Id support to the new userId module for Prebid. This change eliminates the loader and instead uses the "attachIdSystem" method to link in DigiTrust Id submodule to the userId system.
Other information
Previous changes to documentation remains valid.