Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid.js Video #3901

Merged
merged 4 commits into from
Jun 25, 2019
Merged

Prebid.js Video #3901

merged 4 commits into from
Jun 25, 2019

Conversation

ix-prebid-support
Copy link
Contributor

Type of change

  • Feature

Description of change

Configured the IX adapter for the VIDEO ad type with instream and outstream context support.

root and others added 3 commits June 12, 2019 16:57
@bretg
Copy link
Collaborator

bretg commented Jun 12, 2019

@ix-prebid-support - please address build failure.

@ix-prebid-support
Copy link
Contributor Author

Hi @bretg thank-you for flagging we are working to resolve this test case issue and will report back.

@betancourtl
Copy link
Contributor

Waiting for this to be added.

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ix-prebid-support Everything looks good. One small change requested.

modules/ixBidAdapter.js Outdated Show resolved Hide resolved
@ix-prebid-support
Copy link
Contributor Author

@bretg thank-you for your patience the issues have been resolved but we still have an outstanding review from @jaiminpanchal27 otherwise things look good to go here.

@jaiminpanchal27 jaiminpanchal27 merged commit e64360c into prebid:master Jun 25, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 2, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
@ix-prebid-support ix-prebid-support mentioned this pull request Nov 13, 2019
2 tasks
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants