Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bid adapter for seedtag #3915

Merged
merged 3 commits into from
Jul 2, 2019
Merged

Added bid adapter for seedtag #3915

merged 3 commits into from
Jul 2, 2019

Conversation

cabama
Copy link
Contributor

@cabama cabama commented Jun 17, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Adding new bid adapter for seedtag

  • test parameters for validating bids
{
  bidder: 'seedtag',
  params: {
    publisherId: '0000-0000-01',          // required
    adUnitId: '0000',                               // required
    placement: 'banner',                        // required
    adPosition: 0                                    // optional
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer: prebid@seedtag.com
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Link to docs PR

Other information

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cabama,
Thanks for submitting your adaptor. You need to pass vastUrl in the bid object in your adaptor file like this vastUrl: rtbBid.rtb.video.asset_url. vastUrl is a mandatory field for instream videos. Please refer appnexusBidAdapter.js for more info.

modules/seedtagBidAdapter.js Outdated Show resolved Hide resolved
@cabama
Copy link
Contributor Author

cabama commented Jun 19, 2019

From what we have seen in the response documentation our understanding was that vastUrl is not mandatory if the vastXml field is returned. Is this still the case or is vastUrl required?

@sumit116
Copy link
Contributor

sumit116 commented Jun 21, 2019

It seems like vastUrl is not mandatory as per the docs. It requires cacheUrl if vastXml is passed. There are console errors when we run the adaptor and as per discussion with @jpanchal, it seems like the errors need not be handled by the adaptor.

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the adaptor on hello_world page and all unit tests have passed. Test coverage of the adaptor is 80%. The changes are working well against all parameters listed in https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md, hence approving the PR.

@jaiminpanchal27 jaiminpanchal27 merged commit d418f61 into prebid:master Jul 2, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* Added bid adapter for seedtag

* Revert changes to package-lock

* added safe check
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* Added bid adapter for seedtag

* Revert changes to package-lock

* added safe check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants