Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Digitrust support in PBS bid adapter and Rubicon bid adapter #3935

Merged
merged 17 commits into from
Jun 21, 2019
Merged

Digitrust support in PBS bid adapter and Rubicon bid adapter #3935

merged 17 commits into from
Jun 21, 2019

Conversation

msm0504
Copy link
Contributor

@msm0504 msm0504 commented Jun 20, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Get Digitrust, UnifiedID, and PubCommon data from bidRequest and populate on calls to Prebid Server and Rubicon

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

nakamoto and others added 17 commits February 16, 2019 21:30
Add microadBidAdapter
8d635ff
Remove unnecessary encodeURIComponent from microadBidAdapter
3055b90
Submit Advangelists Prebid Adapter
67fb91b
Submit Advangelists Prebid Adapter 1.1
3ebb916
Correct procudtion endpoint for prebid
4f5c451
Merge branch 'microad-bid-adapter' of git://github.com/strong-zero/Pr…
2dc6d1d 
…ebid.js into master-rubicon-clean
Merge remote-tracking branch 'origin/master' into master-rubicon-clean
fa3e081 
# Conflicts:
#	modules/advangelistsBidAdapter.js
#	test/spec/modules/advangelistsBidAdapter_spec.js
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
600a46e 
…ter-remote-updated
Merge branch 'master' of https://github.com/prebid/Prebid.js
7f578b3
Merge branch 'master' of https://github.com/prebid/Prebid.js
176a312
Merge branch 'master' of https://github.com/prebid/Prebid.js
9abf89c
Merge remote-tracking branch 'upstream/master'
6ce04ab
- Get digitrust data from bid request
cabd526 
- Send UnifiedID and PubCommon data to OpenRTB
- Replace lodash with Prebid util functions
1076efb 
- Updated pubcommon id location when sending to OpenRTB
Remove pref property when sending DigiTrust to OpenRTB
a6a51cc
Updated tests to check new user external id locations in request
c8cbd5b
Remove use of array find from unit test
8722812
@bretg bretg requested a review from idettman June 21, 2019 01:47
@bretg bretg changed the title Rubicon digitrust support Digitrust support in PBS bid adapter and Rubicon bid adapter Jun 21, 2019
@jsnellbaker jsnellbaker added the needs 2nd review Core module updates require two approvals from the core team label Jun 21, 2019
idettman
idettman approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit bbd73ce into prebid:master Jun 21, 2019
@bretg
Copy link
Collaborator

bretg commented Jun 25, 2019

docs PR prebid/prebid.github.io#1298

This was referenced Jun 28, 2019
Closed
Closed
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
@msm0504
Digitrust support in PBS bid adapter and Rubicon bid adapter (prebid#…
3471f50 
…3935)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* - Get digitrust data from bid request
- Send UnifiedID and PubCommon data to OpenRTB

* - Replace lodash with Prebid util functions
- Updated pubcommon id location when sending to OpenRTB

* Remove pref property when sending DigiTrust to OpenRTB

* Updated tests to check new user external id locations in request

* Remove use of array find from unit test
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
@msm0504
Digitrust support in PBS bid adapter and Rubicon bid adapter (prebid#…
a248f97 
…3935)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* - Get digitrust data from bid request
- Send UnifiedID and PubCommon data to OpenRTB

* - Replace lodash with Prebid util functions
- Updated pubcommon id location when sending to OpenRTB

* Remove pref property when sending DigiTrust to OpenRTB

* Updated tests to check new user external id locations in request

* Remove use of array find from unit test
@robertrmartinez robertrmartinez deleted the rubicon-digitrust-support branch July 5, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idettman idettman idettman approved these changes

@bretg bretg bretg approved these changes

Assignees

@idettman idettman

Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msm0504 @bretg @idettman @jsnellbaker