Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update outstream prod url #4104

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Conversation

sumit116
Copy link
Contributor

@sumit116 sumit116 commented Aug 21, 2019

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Update outsteram production url throughout prebid.js

  • test parameters for validating bids
   var adUnits = [
           {
               code: 'test-div',
               sizes: [[640, 360]],
               mediaTypes: { video: {playerSize: [640, 480],
                       context: 'outstream',
                       mimes: ['video/mp4']} },
               bids: [
                   {
                       bidder: "trustx",
                       params: {
                           uid: 7697
                       }
                   }
               ]
           }
       ];

Be sure to test the integration with your adserver using the Hello World sample page.

@jsnellbaker jsnellbaker added the needs 2nd review Core module updates require two approvals from the core team label Aug 21, 2019
@@ -6,7 +6,7 @@ import { VIDEO, BANNER } from '../src/mediaTypes';
const BIDDER_CODE = 'grid';
const ENDPOINT_URL = '//grid.bidswitch.net/hb';
const TIME_TO_LIVE = 360;
const RENDERER_URL = '//cdn.adnxs.com/renderer/video/ANOutstreamVideo.js';
const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know if GridBidAdapter and TrustxBidAdapter both want to move to latest version of outstream renderer ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TheMediaGrid, @PWyrembak ,
Your adapters are using an older version of outstream production url, so I went ahead and updated it to the new url. Can you please check and approve this change by reverting to this comment or let me know your feedback if have any other opinion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumit116 @jaiminpanchal27 Approved for trustxBidAdapter.js.
Is it a simple upgrade? Should we expect any performance changes on outstream front?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumit116 we have finished testing of the new url
Approved for merge

@sumit116
Copy link
Contributor Author

Keeping it on hold as @TheMediaGrid in a separate email has asked for this week time to test the new url on their end.

@sumit116 sumit116 merged commit e897d47 into master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants