-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update outstream prod url #4104
Conversation
@@ -6,7 +6,7 @@ import { VIDEO, BANNER } from '../src/mediaTypes'; | |||
const BIDDER_CODE = 'grid'; | |||
const ENDPOINT_URL = '//grid.bidswitch.net/hb'; | |||
const TIME_TO_LIVE = 360; | |||
const RENDERER_URL = '//cdn.adnxs.com/renderer/video/ANOutstreamVideo.js'; | |||
const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if GridBidAdapter
and TrustxBidAdapter
both want to move to latest version of outstream renderer ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TheMediaGrid, @PWyrembak ,
Your adapters are using an older version of outstream production url
, so I went ahead and updated it to the new url. Can you please check and approve this change by reverting to this comment or let me know your feedback if have any other opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumit116 @jaiminpanchal27 Approved for trustxBidAdapter.js.
Is it a simple upgrade? Should we expect any performance changes on outstream front?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumit116 we have finished testing of the new url
Approved for merge
Keeping it |
Type of change
Description of change
Update outsteram production url throughout prebid.js
Be sure to test the integration with your adserver using the Hello World sample page.