E2e tests for Native and Outstream video Ad formats. #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
approved these changes
Aug 28, 2019
jsnellbaker
added
the
needs 2nd review
robertrmartinez
approved these changes
Sep 3, 2019
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR introduces basic End to End tests for Native and Outstream video Ad formats. The tests checks for the followings things:
Also,
browsers.jsonfile has been updated to reflect recent versions for major browsers but care has been taken to not include the latest versions or beta versions.Although, steps have been taken to ensure the tests are robust and have a consistent behaviour, some tests fail in Browserstack when the Ad doesn't render. This behaviour is because sometimes, Browserstack is not able to load the Ad in a given timeframe or the browser glitches out.
Plan to fix this erratic behaviour with Browserstack in a separate PR. Probably, will try updating Browserstack or Webdriver to the latest version, or in worst case, have to research some other Test runner/Frameworks for E2E testing.