Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Video Support for Datablocks Bid Adapter #4195

Merged
merged 14 commits into from
Sep 24, 2019
Merged

Add Video Support for Datablocks Bid Adapter #4195

merged 14 commits into from
Sep 24, 2019

Conversation

htang555
Copy link
Contributor

Type of change

  • [x ] Feature

Description of change

Added Video Support to existing Bid Adapter

  • test parameters for validating bids
{
  bidder: 'datablocks',
  params: {
    host:'search.nutella.datablocks.net',
    sourceId:906295,
    video: {}
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@htang555
Copy link
Contributor Author

Please note the fail on circleci is because of a failure by a different adapter.

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertrmartinez robertrmartinez merged commit 4be8495 into prebid:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants