Merge Valueimpression Bid Adapter to Quantumdex Bid Adapter #5405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
docs PR prebid/prebid.github.io#2077 |
bmwcmw
reviewed
Jul 5, 2020
| var bySlotTargetKey = {}; | ||
| var bySlotSizesCount = {} | ||
|
|
||
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| supportedMediaTypes: ['banner', 'video'], | ||
| aliases: ['qde'], | ||
| aliases: ['valueimpression'], |
There was a problem hiding this comment.
Is expected that the bidder code and default config are using quantumdex but the short name is valueimpression?
There was a problem hiding this comment.
Hello,
Because we are merging the valueimpression adapter with the quantumdex adapter as described in #5370, the valueimpression will be the alias of the quantumdex bid adapter. That's exactly what we want. Thanks
sbrosinski
added a commit
to smaato/Prebid.js
that referenced
this pull request
Jul 10, 2020
* 'master' of github.com:prebid/Prebid.js: (39 commits) Increment pre version Prebid 3.25.0 release Add lotame id system (prebid#5388) Change endpoint (prebid#5459) ozone 2.4.0 adapter updates (prebid#5421) Update AppNexus usersync script (prebid#5473) Eplanning fix: decode parameters (prebid#5448) Teads adapter : Support page referrer and network bandwidth (prebid#5430) Merge Valueimpression Bid Adapter to Quantumdex Bid Adapter (prebid#5405) Criteo - partially restore adapter before PR prebid#4518 following performance issues (prebid#5376) onetagBidAdapter: outstream support (prebid#5435) Vidazoo Adapter: Feature/bidder-version (prebid#5384) adform and adformOpenRTB bid adapters: Added support for userId modules (prebid#5425) proxistore bid adapter: delay request to server by 5 min if there were no bids (prebid#5379) Vidazoo Adapter: Feature/subdomain (prebid#5446) Inskin Bid adapter small changes (prebid#5373) Revert "add AMX adapter (prebid#5383)" (prebid#5455) ATS-change logError to logInfo type (prebid#5443) ATS-identityLinkId - add additional info logging events (prebid#5442) Update padsquad for meta.advertiserDomains (prebid#5439) ...
sbrosinski
added a commit
to smaato/Prebid.js
that referenced
this pull request
Jul 10, 2020
* smaato-adapter: (40 commits) Smaato: Fix test data Increment pre version Prebid 3.25.0 release Add lotame id system (prebid#5388) Change endpoint (prebid#5459) ozone 2.4.0 adapter updates (prebid#5421) Update AppNexus usersync script (prebid#5473) Eplanning fix: decode parameters (prebid#5448) Teads adapter : Support page referrer and network bandwidth (prebid#5430) Merge Valueimpression Bid Adapter to Quantumdex Bid Adapter (prebid#5405) Criteo - partially restore adapter before PR prebid#4518 following performance issues (prebid#5376) onetagBidAdapter: outstream support (prebid#5435) Vidazoo Adapter: Feature/bidder-version (prebid#5384) adform and adformOpenRTB bid adapters: Added support for userId modules (prebid#5425) proxistore bid adapter: delay request to server by 5 min if there were no bids (prebid#5379) Vidazoo Adapter: Feature/subdomain (prebid#5446) Inskin Bid adapter small changes (prebid#5373) Revert "add AMX adapter (prebid#5383)" (prebid#5455) ATS-change logError to logInfo type (prebid#5443) ATS-identityLinkId - add additional info logging events (prebid#5442) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR has solved the issue #5370