Log unsupported ad type only for good bids #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue where bids are returned from the server with a `nobid` field. In that case, bids won't have an ad_type field and an error message is logged that states 'undefined ad type not supported', but bids are still regsitered to the bid manager with status `NO_BID`. This change aims to remove confusion by only loging the error message in cases where a good bid response comes back from the server with an ad_type other than `banner`, which is not currently supported by this adapter.
|
LGTM |
protonate
pushed a commit
that referenced
this pull request
Aug 19, 2016
This addresses an issue where bids are returned from the server with a `nobid` field. In that case, bids won't have an ad_type field and an error message is logged that states 'undefined ad type not supported', but bids are still regsitered to the bid manager with status `NO_BID`. This change aims to remove confusion by only loging the error message in cases where a good bid response comes back from the server with an ad_type other than `banner`, which is not currently supported by this adapter.
protonate
pushed a commit
that referenced
this pull request
Aug 20, 2016
This addresses an issue where bids are returned from the server with a `nobid` field. In that case, bids won't have an ad_type field and an error message is logged that states 'undefined ad type not supported', but bids are still regsitered to the bid manager with status `NO_BID`. This change aims to remove confusion by only loging the error message in cases where a good bid response comes back from the server with an ad_type other than `banner`, which is not currently supported by this adapter.
|
I tried building again after the fix with latest master and im getting src/ajax.js: line 24, col 12, 'method' is not defined. 4 errors ... |
protonate
pushed a commit
that referenced
this pull request
Aug 22, 2016
This addresses an issue where bids are returned from the server with a `nobid` field. In that case, bids won't have an ad_type field and an error message is logged that states 'undefined ad type not supported', but bids are still regsitered to the bid manager with status `NO_BID`. This change aims to remove confusion by only loging the error message in cases where a good bid response comes back from the server with an ad_type other than `banner`, which is not currently supported by this adapter.
marian-r
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 23, 2016
…2.0 to master * commit '40fdbed10c218a993df9e6665797b36f402ded18': (52 commits) Added new adapter for AOL analytics Fixed ES6 features which require a polyfill Updated CHANGELOG Fixed per-adapter timeouts Fixed sorting of per-adapter timeouts Added horizontal rule to delimit the original README part Link to the AOL documentation made more visible Fixed unit tests for AOL analytics Made changes required due to pull from Prebid official Updated README Updated LICENSE Reverted AOL branding restore url.js and modifcations to ajax.js (prebid#551) Log unsupported ad type only for good bids (prebid#547) use var ad instead of incorrect ads in rubicon adapter (prebid#546) Karma opens debug.html by default (prebid#540) Prebid 0.12.0 release Add tests for triplelift adapter. (prebid#531) allows multiple bids to be registered per a slot, related to prebid#496 (prebid#503) Add tests for aardvark adapter. (prebid#529) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue mentioned in #322 where bids are returned from the server with a
nobidfield. In that case, bids won't have anad_typefield and an error message is logged that states 'undefined ad type not supported', but bids are still registered to the bid manager with statusNO_BID. This change aims to remove confusion by only logging the error message in cases where a good bid response comes back from the server with an ad_type other thanbanner, which is not currently supported by this adapter.