Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performax adapter #5480

Merged
merged 3 commits into from Jul 17, 2020
Merged

Performax adapter #5480

merged 3 commits into from Jul 17, 2020

Conversation

VasekProchazka
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Add a new bidder adapter for Performax

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    slotId: "28"
  }
}

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

@VasekProchazka
Copy link
Contributor Author

Docs PR prebid/prebid.github.io#2123

Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, MR looks ok, you just need to fix lint errors you have. Take a look at the circleci output on this PR (basically you just need to replace " with ' in your test file).

I also added recommendation to remove unused functions.

modules/performaxBidAdapter.js Outdated Show resolved Hide resolved
@FilipStamenkovic FilipStamenkovic merged commit b25e57d into prebid:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants