-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onetag update #5503
Merged
Merged
Onetag update #5503
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
662b680
Cambia nome variabile us privacy in getUserSyncs
a8e6d1f
Merge remote-tracking branch 'upstream/master'
ce0e7a8
Merge branch 'master' of https://github.com/prebid/Prebid.js
forazini d2b9fdd
Merge branch 'master' of https://github.com/prebid/Prebid.js
635d40b
Merge remote-tracking branch 'origin/master'
forazini f1b0ede
package-lock
a9392eb
Merge remote-tracking branch 'origin/master'
0a19441
Merge remote-tracking branch 'origin/master'
forazini 06a13ec
Merge remote-tracking branch 'upstream/master'
forazini 18f5fe1
Fixes bugs, adds version
forazini e5b703b
Revert "package-lock"
forazini 8213b5d
Corrects initial adapter version
forazini cc4c95c
Converts bare localStorage access into provided helper's call
forazini File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prebid offers a
storageManager
class to deal with localStorage or cookies. check out, for example, bidder widespaceBidAdapter (https://github.com/prebid/Prebid.js/blob/master/modules/widespaceBidAdapter.js#L9) and how they use it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @musikele , we just pushed the requested changes. Hope you have time enough to review them before your holidays :)