Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media.net Analytics improvements [Bug Fix] #5514

Merged
merged 1 commit into from Jul 23, 2020
Merged

Media.net Analytics improvements [Bug Fix] #5514

merged 1 commit into from Jul 23, 2020

Conversation

monis0395
Copy link
Contributor

@monis0395 monis0395 commented Jul 20, 2020 •
edited

Type of change

  • Bug
  • Feature

Description of change

  • Fixed Native size
  • Fixed size logging
  • Added support for floor price logging
  • Added support for video ad unit details logging

@monis0395 monis0395 force-pushed the floor-param-logging branch 2 times, most recently from 07d8e66 to dbcbc90 Compare July 20, 2020 06:07
@monis0395 monis0395 marked this pull request as ready for review July 20, 2020 07:31
@Fawke Fawke self-requested a review July 23, 2020 10:55
Fawke
Fawke approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke merged commit 7535132 into prebid:master Jul 23, 2020
@Fawke Fawke added the LGTM label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fawke Fawke Fawke approved these changes

Assignees

@Fawke Fawke

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@monis0395 @Fawke @monisq