[Synacormedia] Fix bug with regex regarding ad size #5561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit '25c5ad3b60ffd6b4d3c645dd9bf16bbb4397a346': CAP-1614 - updated docs to show correct size for banner and some other small fixes
* commit 'b6dfbc9a938563c2964d30719a78cde1f15d3740': CAP-1636 support schain object in prebid
* commit 'c934f2d341bea0938cd5b1b75e62030ce5447117': CAP-1636 updated the review comments
* commit 'a26077f86598287d5c7d2f624cd3fec5b0b8d3e1': CAP-1849 - split up banner and video impressions to use format
* commit 'c70d8fc30e44779a8f3f78fa341ad19ad1cf5395': CAP-1879 - added adapter support for consent management module
* commit '6fa31a1fb15b01dae836e70eae708dba1618adfb': CAP-1920 - fix a comparison, and height setting CAP-1920 - update tests and banner CAP-1920 - fixed size bug
harpere
approved these changes
Aug 4, 2020
coreykress
added a commit
to coreykress/Prebid.js
that referenced
this pull request
Aug 13, 2020
* CAP-1614 - updated docs to show correct size for banner and some other small fixes * CAP-1636 support schain object in prebid * CAP-1636 updated the review comments * CAP-1849 - split up banner and video impressions to use format * CAP-1879 - added adapter support for consent management module * CAP-1879 - updates for pr * CAP-1879 - remove unneeded checks * CAP-1920 - fixed size bug * CAP-1920 - update tests and banner * CAP-1920 - fix a comparison, and height setting Co-authored-by: Corey Kress <corey.kress@synacor.com> Co-authored-by: Rajkumar Natarajan <rajkumar.natarajan@synacor.com>
mimenet
pushed a commit
that referenced
this pull request
Aug 17, 2020
* CAP-1614 - updated docs to show correct size for banner and some other small fixes * CAP-1636 support schain object in prebid * CAP-1636 updated the review comments * CAP-1849 - split up banner and video impressions to use format * CAP-1879 - added adapter support for consent management module * CAP-1879 - updates for pr * CAP-1879 - remove unneeded checks * CAP-1920 - fixed size bug * CAP-1920 - update tests and banner * CAP-1920 - fix a comparison, and height setting Co-authored-by: Corey Kress <corey.kress@synacor.com> Co-authored-by: Rajkumar Natarajan <rajkumar.natarajan@synacor.com> Co-authored-by: Corey Kress <corey.kress@synacor.com> Co-authored-by: Rajkumar Natarajan <rajkumar.natarajan@synacor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Our adapter is throwing errors due to a change in the way we pass in ad sizes and a change in our impression id. This PR fixes those errors.