Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

welect: update parameters to match backend specs of tcf2.0 #5613

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

nduitz
Copy link
Contributor

@nduitz nduitz commented Aug 16, 2020

Type of change

  • BidAdapterUpdate

Description of change

This changes the parameter parsing to our backend, so we are working only with tcf2.0 parameters

Documentation update:
prebid/prebid.github.io#2233

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nduitz Looks good, just wanted to mention that GVL ID is not specified. So, if the GDPR Enforcement is included in the build, your adapter may get blocked (If the publisher has listed your adapter under vendorExceptions, it won't).

@bretg bretg changed the title update parameters to match backend specs of tcf2.0 welect: update parameters to match backend specs of tcf2.0 Sep 2, 2020
@Fawke
Copy link
Contributor

Fawke commented Sep 7, 2020

@nduitz Any updates?

Copy link
Contributor Author

@nduitz nduitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fawke sorry I am currently on vacation. I'll look into this by the end of next week

Copy link
Contributor Author

@nduitz nduitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fawke thanks for pointing it out, I added our gvlid to the spec

@Fawke
Copy link
Contributor

Fawke commented Sep 16, 2020

@nduitz Can you also add the key, gvl_id:<<YOUR GVL ID>> in the meta section of the markdown document in this PR? prebid/prebid.github.io#2233

This change was introduced from this PR: prebid/prebid.github.io#2271.

Copy link
Contributor Author

@nduitz nduitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke merged commit 9297612 into prebid:master Sep 22, 2020
@Fawke Fawke added the LGTM label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants