Price Floors: Fix bug when caching floor lookup #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msm0504
reviewed
Sep 1, 2020
msm0504
approved these changes
Sep 1, 2020
robertrmartinez
added
the
needs 2nd review
jsnellbaker
approved these changes
Sep 2, 2020
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* Cannot pass cached floor by reference, adjustments break it! * fix typo Co-authored-by: Leif Wickland <leifwickland@gmail.com> Co-authored-by: Leif Wickland <leifwickland@gmail.com>
BrightMountainMediaInc
added a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
This reverts commit 9d737a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When a floor is initially looked up, the input request params are saved as an offset so we do not have to run the lookup again.
When we find a cached lookup, we were passing the reference of the object, thus any currency adjustments were overwriting the cached value.
Now we pass back a copy of it.