-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial checkin jixie adapter files #5751
Conversation
It is my first time doing anything with git/prebid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jxdeveloper1 please read my comments regarding setting and getting cookies via the storageManager. Thank you
docs PR prebid/prebid.github.io#2338 |
as per suggestion by reviewers, for cookie access, using instead the storagemanager from prebid. Will also fix up the unit test too.
as per suggestion by reviewers, for cookie access, using instead the storagemanager from prebid. the adaptor was updated and now this unit test also updated.
Hello! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello Folks, |
@jxdeveloper1 , |
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page. -- DONE
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information