Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial checkin jixie adapter files #5751

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

jxdeveloper1
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
    bidder: 'jixie',
                params: {
                    unit: "prebidsampleunit"
                }
}

Be sure to test the integration with your adserver using the Hello World sample page. -- DONE

  • contact email of the adapter’s maintainer renee@jixie.io
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@jxdeveloper1
Copy link
Contributor Author

It is my first time doing anything with git/prebid.
I noticed the CircleCI failure is unrelated to the new adaptor (jixie) that I am trying to submit. (don't think jixie adaptor has been even run yet)
ci-err.txt

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jxdeveloper1 please read my comments regarding setting and getting cookies via the storageManager. Thank you

modules/jixieBidAdapter.js Show resolved Hide resolved
@bretg
Copy link
Collaborator

bretg commented Sep 21, 2020

docs PR prebid/prebid.github.io#2338

as per suggestion by reviewers, for cookie access, using instead the storagemanager from prebid.
Will also fix up the unit test too.
as per suggestion by reviewers, for cookie access, using instead the storagemanager from prebid.
the adaptor was updated and now this unit test also updated.
@jxdeveloper1
Copy link
Contributor Author

Hello!
Updated the adaptor and the unit test to handle cookie using storage manager. thanks

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@musikele musikele merged commit 52ff5e6 into prebid:master Sep 22, 2020
@jxdeveloper1
Copy link
Contributor Author

Hello Folks,
I have a question: I can see that the jixie adaptor is in the 4.9.0 release of Prebid.js. My adaptor, test code all in there.
However, when I visit this https://docs.prebid.org/download.html page, in the list there for 4.9.0
I do not see jixie on the list.
Is there something else i need to do?
Thanks in advance!
Renee
Screenshot 2020-09-25 at 9 35 24 AM

@musikele
Copy link
Contributor

musikele commented Sep 28, 2020

@jxdeveloper1 ,
Docs have been updated. Sorry for the delay and thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants