Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature/getNoBidsForAdUnitCode function #5932

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2020

Type of change

  • Bugfix
  • [x ] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add prebid global function to get noBids by adunit much like getBidResponsesForAdUnitCode

Other information

#5931
https://github.com/prebid/prebid.github.io/pull/2498/files

@ghost ghost mentioned this pull request Nov 4, 2020
@robertrmartinez robertrmartinez added the needs 2nd review Core module updates require two approvals from the core team label Nov 9, 2020
@osazos
Copy link
Collaborator

osazos commented Nov 11, 2020

Hi @r-schweitzer,

Can you add this new function to the test file test/spec/api_spec.js?

Also, could you please update the publisher api reference in https://github.com/prebid/prebid.github.io/blob/master/dev-docs/publisher-api-reference.md to reflect this addition

Thanks

@ghost ghost force-pushed the feature/getNoBidsForAdUnitCode branch from 70b5bb5 to 377b57e Compare November 13, 2020 12:48
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osazos osazos added the LGTM label Nov 15, 2020
@osazos osazos merged commit ac686e5 into master Nov 16, 2020
@osazos osazos deleted the feature/getNoBidsForAdUnitCode branch November 16, 2020 17:43
@bretg
Copy link
Collaborator

bretg commented Nov 19, 2020

docs pr prebid/prebid.github.io#2498

stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
* added feature/getNoBidsForAdUnitCode function

* added unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants